Re: [Spice-devel] [spice-server PATCH 7/8] red-record-qxl: replace continue with empty block
On 10/17/2016 12:52 PM, Frediano Ziglio wrote: Spice coding style suggests to use curly braces for while blocks. Signed-off-by: Uri Lublin --- server/red-record-qxl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/red-record-qxl.c b/server/red-record-qxl.c index 8af2c9c..adc487b 100644 --- a/server/red-record-qxl.c +++ b/server/red-record-qxl.c @@ -846,8 +846,8 @@ static void child_output_setup(gpointer user_data) { int fd = GPOINTER_TO_INT(user_data); -while (dup2(fd, STDOUT_FILENO) < 0 && errno == EINTR) -continue; +while (dup2(fd, STDOUT_FILENO) < 0 && errno == EINTR) { +} close(fd); // make sure file is not closed calling exec() There is another occurrence in the same file. Yes, I'll modify both. It's weird to see a close bracket just before a statement, perhaps a combination of the two like while (dup2(fd, STDOUT_FILENO) < 0 && errno == EINTR) { continue; } is more "unexpected" ? OK, I do not find it weird but I can leave the "continue;" in the block. Thanks, Uri ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [spice-server PATCH 7/8] red-record-qxl: replace continue with empty block
> > Spice coding style suggests to use curly braces > for while blocks. > > Signed-off-by: Uri Lublin > --- > server/red-record-qxl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/red-record-qxl.c b/server/red-record-qxl.c > index 8af2c9c..adc487b 100644 > --- a/server/red-record-qxl.c > +++ b/server/red-record-qxl.c > @@ -846,8 +846,8 @@ static void child_output_setup(gpointer user_data) > { > int fd = GPOINTER_TO_INT(user_data); > > -while (dup2(fd, STDOUT_FILENO) < 0 && errno == EINTR) > -continue; > +while (dup2(fd, STDOUT_FILENO) < 0 && errno == EINTR) { > +} > close(fd); > > // make sure file is not closed calling exec() There is another occurrence in the same file. It's weird to see a close bracket just before a statement, perhaps a combination of the two like while (dup2(fd, STDOUT_FILENO) < 0 && errno == EINTR) { continue; } is more "unexpected" ? Frediano ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
[Spice-devel] [spice-server PATCH 7/8] red-record-qxl: replace continue with empty block
Spice coding style suggests to use curly braces for while blocks. Signed-off-by: Uri Lublin --- server/red-record-qxl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/red-record-qxl.c b/server/red-record-qxl.c index 8af2c9c..adc487b 100644 --- a/server/red-record-qxl.c +++ b/server/red-record-qxl.c @@ -846,8 +846,8 @@ static void child_output_setup(gpointer user_data) { int fd = GPOINTER_TO_INT(user_data); -while (dup2(fd, STDOUT_FILENO) < 0 && errno == EINTR) -continue; +while (dup2(fd, STDOUT_FILENO) < 0 && errno == EINTR) { +} close(fd); // make sure file is not closed calling exec() -- 2.7.4 ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel