Re: [PATCH 1/2] drm/qxl: remove unused `count` variable from `qxl_surface_id_alloc()`
On Thu, Mar 28, 2024 at 11:18 AM Maxime Ripard wrote: > > "a while ago" here being 2 hours before your message :) Ah, I meant the original reports that Nathan mentioned in his message. Yeah, the message itself from Nathan happened right before :) > I've added a Closes tag for that report too. > > I've applied both patches to drm-misc-fixes, thanks! My pleasure! Cheers, Miguel
Re: [PATCH 1/2] drm/qxl: remove unused `count` variable from `qxl_surface_id_alloc()`
On Wed, Mar 27, 2024 at 07:14:12PM +0100, Miguel Ojeda wrote: > On Wed, Mar 27, 2024 at 6:56 PM Miguel Ojeda wrote: > > > > Closes: > > https://lore.kernel.org/lkml/caniq72mjc5t4n25sqvysroehxxpxypz4ppznesjhenc3qap...@mail.gmail.com/ > > Should have a [1] at the end. I added it while committing > > Signed-off-by: Miguel Ojeda > > --- > > Given there is a loop going on here, it would be good to double-check > > whether > > this variable was supposed to be used for something useful or if it was > > just a > > remnant of a version previous to v1.4. > > Also, I see Nathan sent meanwhile a message about these two that were > also mentioned/reported a while ago [1]. "a while ago" here being 2 hours before your message :) I've added a Closes tag for that report too. I've applied both patches to drm-misc-fixes, thanks! Maxime signature.asc Description: PGP signature
Re: [PATCH 1/2] drm/qxl: remove unused `count` variable from `qxl_surface_id_alloc()`
On Wed, Mar 27, 2024 at 6:56 PM Miguel Ojeda wrote: > > Closes: > https://lore.kernel.org/lkml/caniq72mjc5t4n25sqvysroehxxpxypz4ppznesjhenc3qap...@mail.gmail.com/ Should have a [1] at the end. > Signed-off-by: Miguel Ojeda > --- > Given there is a loop going on here, it would be good to double-check whether > this variable was supposed to be used for something useful or if it was just a > remnant of a version previous to v1.4. Also, I see Nathan sent meanwhile a message about these two that were also mentioned/reported a while ago [1]. On my side, I noticed these due to my loongarch64 defconfig compile-test with Rust enabled yesterday [2], but I don't want to step on Tom/Colin/Nathan/ClangBuiltLinux's work, so please feel free to do with these patches as you will! Thanks! Cheers, Miguel [1] https://lore.kernel.org/all/20240327163331.GB1153323@dev-arch.thelio-3990X/ [2] https://lore.kernel.org/lkml/caniq72mjc5t4n25sqvysroehxxpxypz4ppznesjhenc3qap...@mail.gmail.com/
