Re: [Spice-devel] [PATCH 05/17] Use RAII to cleanup stream in case of exception or return

2018-02-21 Thread Lukáš Hrázký
On Tue, 2018-02-20 at 18:37 +0100, Christophe de Dinechin wrote: > [Forgot to send, sorry for delay] > > > On 19 Feb 2018, at 19:03, Lukáš Hrázký wrote: > > > > On Fri, 2018-02-16 at 17:59 +0100, Christophe de Dinechin wrote: > > > > On 16 Feb 2018, at 17:40, Frediano Ziglio

Re: [Spice-devel] [PATCH 05/17] Use RAII to cleanup stream in case of exception or return

2018-02-20 Thread Christophe de Dinechin
> On 20 Feb 2018, at 22:38, Jonathon Jongsma wrote: > > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: >> From: Christophe de Dinechin >> >> Get rid of C-style 'goto done' in do_capture. >> Get rid of global streamfd, pass it around

Re: [Spice-devel] [PATCH 05/17] Use RAII to cleanup stream in case of exception or return

2018-02-20 Thread Jonathon Jongsma
On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > Get rid of C-style 'goto done' in do_capture. > Get rid of global streamfd, pass it around (cleaned up in later > patch) > Fixes a race condition, make sure we only use stream

Re: [Spice-devel] [PATCH 05/17] Use RAII to cleanup stream in case of exception or return

2018-02-20 Thread Christophe de Dinechin
[Forgot to send, sorry for delay] > On 19 Feb 2018, at 19:03, Lukáš Hrázký wrote: > > On Fri, 2018-02-16 at 17:59 +0100, Christophe de Dinechin wrote: >>> On 16 Feb 2018, at 17:40, Frediano Ziglio wrote: >>> From: Christophe de Dinechin

Re: [Spice-devel] [PATCH 05/17] Use RAII to cleanup stream in case of exception or return

2018-02-19 Thread Lukáš Hrázký
On Fri, 2018-02-16 at 17:59 +0100, Christophe de Dinechin wrote: > > On 16 Feb 2018, at 17:40, Frediano Ziglio wrote: > > > > > > > > From: Christophe de Dinechin > > > > > > Get rid of C-style 'goto done' in do_capture. > > > Get rid of global

Re: [Spice-devel] [PATCH 05/17] Use RAII to cleanup stream in case of exception or return

2018-02-16 Thread Christophe de Dinechin
> On 16 Feb 2018, at 17:40, Frediano Ziglio wrote: > >> >> From: Christophe de Dinechin >> >> Get rid of C-style 'goto done' in do_capture. >> Get rid of global streamfd, pass it around (cleaned up in later patch) >> Fixes a race condition, make sure

Re: [Spice-devel] [PATCH 05/17] Use RAII to cleanup stream in case of exception or return

2018-02-16 Thread Frediano Ziglio
> > From: Christophe de Dinechin > > Get rid of C-style 'goto done' in do_capture. > Get rid of global streamfd, pass it around (cleaned up in later patch) > Fixes a race condition, make sure we only use stream after opening > > Signed-off-by: Christophe de Dinechin