Re: [Spice-devel] [PATCH 07/17] Get rid of C-style memset initializations, use C++ style aggregates

> On 23 Feb 2018, at 12:08, Christophe Fergeau wrote: > > On Fri, Feb 23, 2018 at 12:01:59PM +0100, Christophe de Dinechin wrote: >> >> >>> On 23 Feb 2018, at 10:53, Christophe Fergeau wrote: >>> >>> Given the lengthy debate over what is mostly a

Re: [Spice-devel] [PATCH 07/17] Get rid of C-style memset initializations, use C++ style aggregates

On Fri, Feb 23, 2018 at 12:01:59PM +0100, Christophe de Dinechin wrote: > > > > On 23 Feb 2018, at 10:53, Christophe Fergeau wrote: > > > > Given the lengthy debate over what is mostly a small cosmetic patch, I > > suggest that we postpone this one for now and drop it from

Re: [Spice-devel] [PATCH 07/17] Get rid of C-style memset initializations, use C++ style aggregates

> On 23 Feb 2018, at 10:53, Christophe Fergeau wrote: > > Given the lengthy debate over what is mostly a small cosmetic patch, I > suggest that we postpone this one for now and drop it from the series. memset in C++ code is not just a style issue, it’s dangerous. It

Re: [Spice-devel] [PATCH 07/17] Get rid of C-style memset initializations, use C++ style aggregates

> On 22 Feb 2018, at 19:03, Frediano Ziglio wrote: > >> >> [Indeed, I had not sent this reply, took time to check standard and >> compilers] >> >>> On 20 Feb 2018, at 12:31, Frediano Ziglio wrote: >>> > On 20 Feb 2018, at 10:39, Lukáš Hrázký

Re: [Spice-devel] [PATCH 07/17] Get rid of C-style memset initializations, use C++ style aggregates

Given the lengthy debate over what is mostly a small cosmetic patch, I suggest that we postpone this one for now and drop it from the series. Christophe On Fri, Feb 16, 2018 at 05:15:37PM +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > >

Re: [Spice-devel] [PATCH 07/17] Get rid of C-style memset initializations, use C++ style aggregates

[Indeed, I had not sent this reply, took time to check standard and compilers] > On 20 Feb 2018, at 12:31, Frediano Ziglio wrote: > >>> On 20 Feb 2018, at 10:39, Lukáš Hrázký wrote: >>> >>> On Tue, 2018-02-20 at 10:18 +0100, Christophe de Dinechin

Re: [Spice-devel] [PATCH 07/17] Get rid of C-style memset initializations, use C++ style aggregates

> > On 20 Feb 2018, at 10:39, Lukáš Hrázký wrote: > > > > On Tue, 2018-02-20 at 10:18 +0100, Christophe de Dinechin wrote: > >>> On Feb 19, 2018, at 7:19 PM, Lukáš Hrázký wrote: > >>> > >>> On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote:

Re: [Spice-devel] [PATCH 07/17] Get rid of C-style memset initializations, use C++ style aggregates

> On 20 Feb 2018, at 10:39, Lukáš Hrázký wrote: > > On Tue, 2018-02-20 at 10:18 +0100, Christophe de Dinechin wrote: >>> On Feb 19, 2018, at 7:19 PM, Lukáš Hrázký wrote: >>> >>> On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote:

Re: [Spice-devel] [PATCH 07/17] Get rid of C-style memset initializations, use C++ style aggregates

On Tue, 2018-02-20 at 10:18 +0100, Christophe de Dinechin wrote: > > On Feb 19, 2018, at 7:19 PM, Lukáš Hrázký wrote: > > > > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > > > From: Christophe de Dinechin > > > > > > Signed-off-by:

Re: [Spice-devel] [PATCH 07/17] Get rid of C-style memset initializations, use C++ style aggregates

> On Feb 19, 2018, at 7:19 PM, Lukáš Hrázký wrote: > > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: >> From: Christophe de Dinechin >> >> Signed-off-by: Christophe de Dinechin >> --- >>

Re: [Spice-devel] [PATCH 07/17] Get rid of C-style memset initializations, use C++ style aggregates

On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 47 > ++- > 1 file changed, 28