Re: [Spice-devel] [PATCH 2/2] OpenSSL from 1.1.0 is thread safe by default

2016-09-15 Thread Christophe Fergeau 
Hey,

On Thu, Sep 15, 2016 at 12:24:15AM +0200, Sebastian Andrzej Siewior wrote:
> On 2016-08-11 14:22:59 [+0100], Frediano Ziglio wrote:
> > +++ b/server/reds.c
> > @@ -2771,6 +2771,7 @@ static int ssl_password_cb(char *buf, int size, int 
> > flags, void *userdata)
> >  return (strlen(pass));
> >  }
> >  
> > +#if OPENSSL_VERSION_NUMBER < 0x101FL
> >  static unsigned long pthreads_thread_id(void)
> >  {
> >  unsigned long ret;
> 
> This seems to be part of the spice git. I am looking at spice-gtk and
> this seems to lack 1.1.0 support. Is someone looking at this by any
> chance? :)

I took a look at that some time ago, and hit some issues porting
spice_channel_load_ca() which uses X509_LOOKUP/X509_LOOKUP_METHOD.
I got the impression from the thread at
https://mta.openssl.org/pipermail/openssl-dev/2016-April/006654.html
that openssl 1.1.0 was missing some methods to let us do what we need
(or maybe it's there but I got lost in the API :)
So I stop trying the port after finding that email. This was 2.5 months
ago, maybe these accessors have been added before the final release(?)

Christophe


signature.asc
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH 2/2] OpenSSL from 1.1.0 is thread safe by default

2016-09-15 Thread Sebastian Andrzej Siewior 
On 2016-08-11 14:22:59 [+0100], Frediano Ziglio wrote:
> +++ b/server/reds.c
> @@ -2771,6 +2771,7 @@ static int ssl_password_cb(char *buf, int size, int 
> flags, void *userdata)
>  return (strlen(pass));
>  }
>  
> +#if OPENSSL_VERSION_NUMBER < 0x101FL
>  static unsigned long pthreads_thread_id(void)
>  {
>  unsigned long ret;

This seems to be part of the spice git. I am looking at spice-gtk and
this seems to lack 1.1.0 support. Is someone looking at this by any
chance? :)

Sebastian
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH 2/2] OpenSSL from 1.1.0 is thread safe by default

2016-08-12 Thread Pavel Grunt 
ack

On Thu, 2016-08-11 at 14:22 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio 
> ---
>  server/reds.c | 6 ++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/server/reds.c b/server/reds.c
> index f74c8d3..c3780e0 100644
> --- a/server/reds.c
> +++ b/server/reds.c
> @@ -2771,6 +2771,7 @@ static int ssl_password_cb(char *buf, int size, int
> flags, void *userdata)
>  return (strlen(pass));
>  }
>  
> +#if OPENSSL_VERSION_NUMBER < 0x101FL
>  static unsigned long pthreads_thread_id(void)
>  {
>  unsigned long ret;
> @@ -2808,6 +2809,11 @@ static void openssl_thread_setup(void)
>  CRYPTO_set_id_callback(pthreads_thread_id);
>  CRYPTO_set_locking_callback(pthreads_locking_callback);
>  }
> +#else
> +static inline void openssl_thread_setup(void)
> +{
> +}
> +#endif
>  
>  static gpointer openssl_global_init(gpointer arg)
>  {
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel