Re: [Spice-devel] [PATCH spice-common 1/2] canvas_base: Check for overflows decoding LZ4

2018-07-11 Thread Jonathon Jongsma
On Wed, 2018-07-11 at 13:21 -0400, Frediano Ziglio wrote: > > > > On Tue, 2018-07-10 at 14:35 +0100, Frediano Ziglio wrote: > > > Check we have enough data before reading. > > > > Check *that* we have... > > > > updated, thanks > > > > This could lead to read buffer overflows being undetected.

Re: [Spice-devel] [PATCH spice-common 1/2] canvas_base: Check for overflows decoding LZ4

2018-07-11 Thread Frediano Ziglio
> > On Tue, 2018-07-10 at 14:35 +0100, Frediano Ziglio wrote: > > Check we have enough data before reading. > > Check *that* we have... > updated, thanks > > This could lead to read buffer overflows being undetected. > > This is not a security issue, read happens only in the client not > > cau

Re: [Spice-devel] [PATCH spice-common 1/2] canvas_base: Check for overflows decoding LZ4

2018-07-11 Thread Jonathon Jongsma
On Tue, 2018-07-10 at 14:35 +0100, Frediano Ziglio wrote: > Check we have enough data before reading. Check *that* we have... > This could lead to read buffer overflows being undetected. > This is not a security issue, read happens only in the client not > causing > any information leakage, maxim