Re: [Spice-devel] [PATCH spice-common 2/2] log: remove spice_static_assert macro

> On Mon, Jun 12, 2017 at 3:04 PM Marc-André Lureau < > marcandre.lur...@redhat.com > wrote: > > Hi > > > - Original Message - > > > > The macro was misused and not doing static check. > > > > Spice have other working static check macros to use. > > > > The macro is used only by

Re: [Spice-devel] [PATCH spice-common 2/2] log: remove spice_static_assert macro

On Mon, Jun 12, 2017 at 3:04 PM Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > Hi > > - Original Message - > > The macro was misused and not doing static check. > > Spice have other working static check macros to use. > > The macro is used only by spice-common so removing it >

Re: [Spice-devel] [PATCH spice-common 2/2] log: remove spice_static_assert macro

Hi - Original Message - > The macro was misused and not doing static check. > Spice have other working static check macros to use. > The macro is used only by spice-common so removing it > does not cause issues to other depending projects. > > Signed-off-by: Frediano Ziglio

Re: [Spice-devel] [PATCH spice-common 2/2] log: remove spice_static_assert macro

> > On Mon, Jun 12, 2017 at 07:46:07AM -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > On Mon, Jun 12, 2017 at 06:26:58AM -0400, Frediano Ziglio wrote: > > > > > > > > > > > > > I think we should replace SPICE_VERIFY / verify with G_STATIC* > > > > > > >

Re: [Spice-devel] [PATCH spice-common 2/2] log: remove spice_static_assert macro

On Mon, Jun 12, 2017 at 07:46:07AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Mon, Jun 12, 2017 at 06:26:58AM -0400, Frediano Ziglio wrote: > > > > > > > > > > > I think we should replace SPICE_VERIFY / verify with G_STATIC* > > > > > > equivalents. > > > > > >

Re: [Spice-devel] [PATCH spice-common 2/2] log: remove spice_static_assert macro

Hi - Original Message - > On Mon, Jun 12, 2017 at 06:26:58AM -0400, Frediano Ziglio wrote: > > > > > > > > > I think we should replace SPICE_VERIFY / verify with G_STATIC* > > > > > equivalents. > > > > > > > > > > > > > We actually can't for compatibility reason. Some version of GLib

Re: [Spice-devel] [PATCH spice-common 2/2] log: remove spice_static_assert macro

On Mon, Jun 12, 2017 at 06:26:58AM -0400, Frediano Ziglio wrote: > > > > > > > I think we should replace SPICE_VERIFY / verify with G_STATIC* > > > > equivalents. > > > > > > > > > > We actually can't for compatibility reason. Some version of GLib have > > > broken macros and we still claim

Re: [Spice-devel] [PATCH spice-common 2/2] log: remove spice_static_assert macro

> > Hi > > - Original Message - > > > > > > Hi > > > > > > - Original Message - > > > > The macro was misused and not doing static check. > > > > Spice have other working static check macros to use. > > > > The macro is used only by spice-common so removing it > > > > does not

Re: [Spice-devel] [PATCH spice-common 2/2] log: remove spice_static_assert macro

Hi - Original Message - > > > > Hi > > > > - Original Message - > > > The macro was misused and not doing static check. > > > Spice have other working static check macros to use. > > > The macro is used only by spice-common so removing it > > > does not cause issues to other

Re: [Spice-devel] [PATCH spice-common 2/2] log: remove spice_static_assert macro

> > Hi > > - Original Message - > > The macro was misused and not doing static check. > > Spice have other working static check macros to use. > > The macro is used only by spice-common so removing it > > does not cause issues to other depending projects. > > > > See also "[PATCH

Re: [Spice-devel] [PATCH spice-common 2/2] log: remove spice_static_assert macro

Hi - Original Message - > The macro was misused and not doing static check. > Spice have other working static check macros to use. > The macro is used only by spice-common so removing it > does not cause issues to other depending projects. > See also "[PATCH spice-common 1/4] log: