On Tue, Mar 17, 2020 at 6:10 PM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> On Dienstag, 17. März 2020 07:53:26 CET Keiichi Watanabe wrote:
> > > > diff --git a/include/uapi/linux/virtio_video.h
> > > > b/include/uapi/linux/virtio_video.h new file mode 100644
> > > > index ..0dd98a2237c6
>
Hi Keiichi,
On Dienstag, 17. März 2020 07:53:26 CET Keiichi Watanabe wrote:
> > > diff --git a/include/uapi/linux/virtio_video.h
> > > b/include/uapi/linux/virtio_video.h new file mode 100644
> > > index ..0dd98a2237c6
> > > --- /dev/null
> > > +++ b/include/uapi/linux/virtio_video.h
> > diff --git a/include/uapi/linux/virtio_video.h
> > b/include/uapi/linux/virtio_video.h
> > new file mode 100644
> > index ..0dd98a2237c6
> > --- /dev/null
> > +++ b/include/uapi/linux/virtio_video.h
> > @@ -0,0 +1,469 @@
> > +/* SPDX-License-Identifier: GPL-2.0+ */
>
> I suspect
Hi Tomasz,
On Freitag, 13. März 2020 12:11:51 CET Tomasz Figa wrote:
> On Fri, Mar 13, 2020 at 11:27 AM Dmitry Sepp
>
> wrote:
> > Hi Tomasz,
> >
> > On Freitag, 13. März 2020 11:05:35 CET Tomasz Figa wrote:
> > > On Thu, Mar 12, 2020 at 12:48 PM Dmitry Sepp
> > >
> > > wrote:
> > > > Hi
On Fri, Mar 13, 2020 at 11:27 AM Dmitry Sepp
wrote:
>
> Hi Tomasz,
>
> On Freitag, 13. März 2020 11:05:35 CET Tomasz Figa wrote:
> > On Thu, Mar 12, 2020 at 12:48 PM Dmitry Sepp
> >
> > wrote:
> > > Hi Hans,
> > >
> > > One more thing:
> > > > GFP_DMA? That's unusual. I'd expect GFP_DMA32. All
On Thu, Mar 12, 2020 at 12:48 PM Dmitry Sepp
wrote:
>
> Hi Hans,
>
> One more thing:
>
> > GFP_DMA? That's unusual. I'd expect GFP_DMA32. All V4L2 drivers use that.
>
> GFP_DMA32 had no effect for me on arm64. Probably I need to recheck.
>
What's the reason to use any specific GFP flags at all?
Hi Tomasz,
On Freitag, 13. März 2020 11:05:35 CET Tomasz Figa wrote:
> On Thu, Mar 12, 2020 at 12:48 PM Dmitry Sepp
>
> wrote:
> > Hi Hans,
> >
> > One more thing:
> > > GFP_DMA? That's unusual. I'd expect GFP_DMA32. All V4L2 drivers use
> > > that.
> >
> > GFP_DMA32 had no effect for me on
Hi Hans,
One more thing:
> GFP_DMA? That's unusual. I'd expect GFP_DMA32. All V4L2 drivers use that.
GFP_DMA32 had no effect for me on arm64. Probably I need to recheck.
Best regards,
Dmitry.
On Donnerstag, 12. März 2020 11:18:26 CET Hans Verkuil wrote:
> On 3/12/20 11:15 AM, Dmitry Sepp
On 3/12/20 11:15 AM, Dmitry Sepp wrote:
> Hi Hans,
>
> Thank you for your great detailed review!
>
> I won't provide inline answers as your comments totally make sense. There is
> only one thing I want to mention:
>
>>> + struct video_plane_format plane_format[VIRTIO_VIDEO_MAX_PLANES];
>>
>>
