Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

On Thu, Feb 15, 2018 at 04:04:57PM +0100, Christophe de Dinechin wrote: > > This style guide only indicates what we aim to achieve. It does not > necessarily reflect the current state of the code. > > What about adding: > > Consistency matters. It may be preferable to ignore a

Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

> On 15 Feb 2018, at 15:55, Christophe Fergeau wrote: > > On Thu, Feb 15, 2018 at 03:25:23PM +0100, Christophe de Dinechin wrote: >> >> >>> On 15 Feb 2018, at 13:41, Christophe Fergeau wrote: >>> >>> On Thu, Feb 15, 2018 at 11:55:44AM +0100,

Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

On Thu, Feb 15, 2018 at 03:25:23PM +0100, Christophe de Dinechin wrote: > > > > On 15 Feb 2018, at 13:41, Christophe Fergeau wrote: > > > > On Thu, Feb 15, 2018 at 11:55:44AM +0100, Christophe de Dinechin wrote: > >> Now, Christophe’s arguments are that > >> > >> 1) we

Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

> On 15 Feb 2018, at 13:41, Christophe Fergeau wrote: > > On Thu, Feb 15, 2018 at 11:55:44AM +0100, Christophe de Dinechin wrote: >> Now, Christophe’s arguments are that >> >> 1) we should not write guidelines that are inconsistent with existing code. >> 2) this is in the

Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

On Thu, Feb 15, 2018 at 11:55:44AM +0100, Christophe de Dinechin wrote: > Now, Christophe’s arguments are that > > 1) we should not write guidelines that are inconsistent with existing code. > 2) this is in the server codebase, so we should server rules > > Problem is with 2, really. > > We

Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

> > > On 15 Feb 2018, at 11:43, Frediano Ziglio wrote: > > > >> > >> On Thu, Feb 15, 2018 at 10:56:49AM +0100, Lukáš Hrázký wrote: > >>> On Wed, 2018-02-14 at 22:43 +0100, Christophe de Dinechin wrote: > > On 14 Feb 2018, at 17:29, Christophe Fergeau

Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

> On 15 Feb 2018, at 11:43, Frediano Ziglio wrote: > >> >> On Thu, Feb 15, 2018 at 10:56:49AM +0100, Lukáš Hrázký wrote: >>> On Wed, 2018-02-14 at 22:43 +0100, Christophe de Dinechin wrote: > On 14 Feb 2018, at 17:29, Christophe Fergeau >

Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

> > On Thu, Feb 15, 2018 at 10:56:49AM +0100, Lukáš Hrázký wrote: > > On Wed, 2018-02-14 at 22:43 +0100, Christophe de Dinechin wrote: > > > > On 14 Feb 2018, at 17:29, Christophe Fergeau > > > > wrote: > > > > > > > > This changes the suggested style to what is currently

Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

On Thu, Feb 15, 2018 at 10:56:49AM +0100, Lukáš Hrázký wrote: > On Wed, 2018-02-14 at 22:43 +0100, Christophe de Dinechin wrote: > > > On 14 Feb 2018, at 17:29, Christophe Fergeau wrote: > > > > > > This changes the suggested style to what is currently used in > > >

Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

On Wed, 2018-02-14 at 22:43 +0100, Christophe de Dinechin wrote: > > On 14 Feb 2018, at 17:29, Christophe Fergeau wrote: > > > > This changes the suggested style to what is currently used in > > spice-server codebase. This also removes a few sentences which > > are not

Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

On Wed, Feb 14, 2018 at 10:43:26PM +0100, Christophe de Dinechin wrote: > > > > On 14 Feb 2018, at 17:29, Christophe Fergeau wrote: > > > > This changes the suggested style to what is currently used in > > spice-server codebase. This also removes a few sentences which > >

Re: [Spice-devel] [spice-server] style: Slight tweak to the header guard section

> On 14 Feb 2018, at 17:29, Christophe Fergeau wrote: > > This changes the suggested style to what is currently used in > spice-server codebase. This also removes a few sentences which > are not really related to how one should format their header guards. > >