Re: [Spice-devel] [spice-server PATCH 3/3] init ssl connection: return quickly if link is null

2017-07-19 Thread Uri Lublin
On 07/17/2017 11:17 AM, Frediano Ziglio wrote: On Sun, 2017-07-16 at 18:47 +0300, Uri Lublin wrote: Under error: 'link' fields are being accessed, so it's wrong to goto error with link == NULL. Instead, return immediately. Found by coverity. Signed-off-by: Uri Lublin Acked-by: Pavel Grunt

Re: [Spice-devel] [spice-server PATCH 3/3] init ssl connection: return quickly if link is null

2017-07-17 Thread Frediano Ziglio
> > On Sun, 2017-07-16 at 18:47 +0300, Uri Lublin wrote: > > Under error: 'link' fields are being accessed, so it's > > wrong to goto error with link == NULL. > > > > Instead, return immediately. > > > > Found by coverity. > > > > Signed-off-by: Uri Lublin > Acked-by: Pavel Grunt > > --- > >

Re: [Spice-devel] [spice-server PATCH 3/3] init ssl connection: return quickly if link is null

2017-07-17 Thread Pavel Grunt
On Sun, 2017-07-16 at 18:47 +0300, Uri Lublin wrote: > Under error: 'link' fields are being accessed, so it's > wrong to goto error with link == NULL. > > Instead, return immediately. > > Found by coverity. > > Signed-off-by: Uri Lublin Acked-by: Pavel Grunt > --- > server/reds.c | 2 +- > 1