Re: [Spice-devel] [spice-server v2 0/7] Add test-listen test case
On Mon, Mar 12, 2018 at 01:36:59PM -0400, Frediano Ziglio wrote: > Still not convinced about the glib version bump but as > nobody complained and as is silently removing RHEL 6 support which > I agree with, I'm fine with it. +1 that it should be fine to bump it and drop RHEL 6 support. To put it simple, I don't see we rebasing rhel6 and porting code is already quite hard with all the refactoring. We could add this to release notes if you feel like it ;) Cheers, toso signature.asc Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
Re: [Spice-devel] [spice-server v2 0/7] Add test-listen test case
> > While working on some bug/new feature for SPICE, I added a test case for > our spice_server_set_port/_set_tls/... API. While the work I did this > for still needs some work, this test case should be good enough on its > own. > > Christophe > > Christophe Fergeau (7): > reds: Close sockets when failing to watch them > build: Bump glib version > tests: basic-event-loop: Silence debug message > test-listen: Add test case for port/address configuration > test-listen: Add event loop helpers > test-listen: Add TLS test > test-listen: Add Unix socket test > > configure.ac| 7 +- > server/reds.c | 34 ++-- > server/tests/Makefile.am| 5 +- > server/tests/basic-event-loop.c | 2 +- > server/tests/test-listen.c | 371 > > 5 files changed, 402 insertions(+), 17 deletions(-) > create mode 100644 server/tests/test-listen.c > There are some minor double empty line added and remove on following patches, maybe better to avoid them. Otherwise for the series: Acked-by: Frediano Ziglio Still not convinced about the glib version bump but as nobody complained and as is silently removing RHEL 6 support which I agree with, I'm fine with it. Frediano ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
