> > In my testing (x86_64/gcc), this had no impact on the resulting binary, > building with/without it gives the same stripped binary save for its > buildid. > The check for -fvisibility in configure.ac is kept as this is going to > be useful when we ship dlopen'ed plugins. > > Signed-off-by: Christophe Fergeau <cferg...@redhat.com> > --- > Here is what the patch would look like if we keep the configure.ac check > for future usage. > > Christophe > > > src/Makefile.am | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/Makefile.am b/src/Makefile.am > index 3717b5c..857d763 100644 > --- a/src/Makefile.am > +++ b/src/Makefile.am > @@ -16,12 +16,10 @@ AM_CPPFLAGS = \ > $(NULL) > > AM_CFLAGS = \ > - $(VISIBILITY_HIDDEN_CFLAGS) \ > $(WARN_CFLAGS) \ > $(NULL) > > AM_CXXFLAGS = \ > - $(VISIBILITY_HIDDEN_CFLAGS) \ > $(WARN_CXXFLAGS) \ > $(NULL) >
Acked-by: Frediano Ziglio <fzig...@redhat.com> Not sure if with -fPIE and x86 this won't change slightly. Frediano _______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
