Re: [Spice-devel] udscs: Fix a potential NULL pointer dereference

2016-12-01 Thread Francois Gouget
On Thu, 1 Dec 2016, Christophe Fergeau wrote: > On Thu, Dec 01, 2016 at 05:19:33AM +0100, Francois Gouget wrote: > > udscs_server_fill_fds() should accept being passed a NULL pointer. > > I would reword the commit log a bit, like "udscs_server_fill_fds() is > dereferencing the 'server' pointer,

Re: [Spice-devel] udscs: Fix a potential NULL pointer dereference

2016-12-01 Thread Christophe Fergeau
On Thu, Dec 01, 2016 at 05:19:33AM +0100, Francois Gouget wrote: > udscs_server_fill_fds() should accept being passed a NULL pointer. I would reword the commit log a bit, like "udscs_server_fill_fds() is dereferencing the 'server' pointer, and then checks if it's NULL. This commit makes sure the