Re: [sqlite] Bug: SQLite shell does not build on Windows with SQLITE_OMIT_COMPLETE

2018-11-16 Thread Victor Costan
Thank you very much, Dan! I was about to come back to report that my fix is incorrect. Your fix does the trick. Thank you! Victor On Fri, Nov 16, 2018 at 6:38 AM Dan Kennedy wrote: > On 11/16/2018 08:41 PM, Victor Costan wrote: > > The amalgamation build ships two definitions of

Re: [sqlite] Bug: SQLite shell does not build on Windows with SQLITE_OMIT_COMPLETE

2018-11-16 Thread Dan Kennedy
On 11/16/2018 08:41 PM, Victor Costan wrote: The amalgamation build ships two definitions of sqlite3_complete(). Most builds use the one in sqlite3.c. If SQLITE_OMIT_COMPLETE is defined, shell.c supplies a stub definition -- thank you very much for adding that! Unfortunately, the stub

[sqlite] Bug: SQLite shell does not build on Windows with SQLITE_OMIT_COMPLETE

2018-11-16 Thread Victor Costan
The amalgamation build ships two definitions of sqlite3_complete(). Most builds use the one in sqlite3.c. If SQLITE_OMIT_COMPLETE is defined, shell.c supplies a stub definition -- thank you very much for adding that! Unfortunately, the stub definition in shell.c does not have the SQLITE_API

Re: [sqlite] Bug: Incorrect fsdir result

2018-11-16 Thread Richard Hipp
On 11/15/18, Jake Thaw wrote: > The following returns an erroneous fsdir error. Tested on macOS 10.13.6. > > SQLite version 3.25.3 2018-11-05 20:37:38 > Enter ".help" for usage hints. > Connected to a transient in-memory database. > Use ".open FILENAME" to reopen on a persistent database. >

Re: [sqlite] Out of bounds memory reads triggered by sqlite tests (testfixture/fuzzcheck)

2018-11-16 Thread Hanno Böck
It seems these have now been fixed with these commits: https://www.sqlite.org/src/info/4e38f27b55030e90 https://www.sqlite.org/src/info/a62e6b593b59eae4 -- Hanno Böck https://hboeck.de/ mail/jabber: ha...@hboeck.de GPG: FE73757FA60E4E21B937579FA5880072BBB51E42