Re: [sqlite] General Amalgamation vs Your Own

2019-09-21 Thread Keith Medcalf
On Saturday, 21 September, 2019 22:35, Stephen Chrzanowski : >Thanks for all this info. >No, I have not made a single change to the amalgamation that has been >provided by sqlite.org. The most I've done is read, line by line, >through the first meg or so of source code, as well as setup an

Re: [sqlite] How to install REGEXP support?

2019-09-21 Thread Jens Alfke
On Sep 19, 2019, at 7:21 PM, Peng Yu wrote: > > My question is `But it is not clear how to install it for sqlite3 installed by > homebrew.` That sounds more like a question to ask the Homebrew community; it isn’t really related to SQLite directly. SQLite is just making a system call to load a

Re: [sqlite] General Amalgamation vs Your Own

2019-09-21 Thread Stephen Chrzanowski
Thanks for all this info. No, I have not made a single change to the amalgamation that has been provided by sqlite.org. The most I've done is read, line by line, through the first meg or so of source code, as well as setup an environment where I specifically can build sqlite3.dll for fun. The

Re: [sqlite] General Amalgamation vs Your Own

2019-09-21 Thread Warren Young
On Sep 21, 2019, at 11:29 AM, Stephen Chrzanowski wrote: > > How does one have their own code base for SQLite, with their own customer > logic or functionality or whatever, then, have updates provided by the > SQLite team implemented in when updates and such are provided? What kind of code are

Re: [sqlite] [EXTERNAL] Group-by and order-by-desc does not work as expected

2019-09-21 Thread Fredrik Larsen
Good to know that I was not to far off target then. But fixing issues in less than a day of reporting? On a Saturday? Who does that? I was planning to feel happy about solving this issue.. :) Fredrik On Sat, Sep 21, 2019 at 9:31 PM Dan Kennedy wrote: > > On 22/9/62 02:25, Fredrik Larsen wrote:

Re: [sqlite] [EXTERNAL] Group-by and order-by-desc does not work as expected

2019-09-21 Thread Dan Kennedy
On 22/9/62 02:25, Fredrik Larsen wrote: Interesting, very similar change but not fully idenctial. In my patch, I created a sqlite3ExprListCompareIgnoreButUpdateSort, and used this function from line 6239. This function ignores the sort part when comparing expressions, but will update the

Re: [sqlite] [EXTERNAL] Group-by and order-by-desc does not work as expected

2019-09-21 Thread Fredrik Larsen
Interesting, very similar change but not fully idenctial. In my patch, I created a sqlite3ExprListCompareIgnoreButUpdateSort, and used this function from line 6239. This function ignores the sort part when comparing expressions, but will update the GroupBy sortOrder field if expressions are found

Re: [sqlite] [EXTERNAL] Group-by and order-by-desc does not work as expected

2019-09-21 Thread Keith Medcalf
See Dan's checkin on trunk for this issue. https://www.sqlite.org/src/info/20f7951bb238ddc0 >-Original Message- >From: sqlite-users On >Behalf Of Fredrik Larsen >Sent: Saturday, 21 September, 2019 08:12 >To: SQLite mailing list >Subject: Re: [sqlite] [EXTERNAL] Group-by and

Re: [sqlite] General Amalgamation vs Your Own

2019-09-21 Thread Richard Hipp
On 9/21/19, Stephen Chrzanowski wrote: > > How does one have their own code base for SQLite, with their own customer > logic or functionality or whatever, then, have updates provided by the > SQLite team implemented in when updates and such are provided? >

[sqlite] General Amalgamation vs Your Own

2019-09-21 Thread Stephen Chrzanowski
With a post that someone made here, and the thought that I've been running in my head over the past while... How does one have their own code base for SQLite, with their own customer logic or functionality or whatever, then, have updates provided by the SQLite team implemented in when updates and

Re: [sqlite] [EXTERNAL] Group-by and order-by-desc does not work as expected

2019-09-21 Thread Fredrik Larsen
To clarify; GROUP-BY does not really have ordering, but in the SQLite implementation, GROUP-BY and ORDER-BY is very closely related as expected, and it is possible to set a GROUP-BY direction in code (it is default 0 -> ASC). So thats what I did. Also, some other modifications very required to

Re: [sqlite] [EXTERNAL] Group-by and order-by-desc does not work as expected

2019-09-21 Thread Fredrik Larsen
Your last sentence got me thinking. So I downloaded the source, modified the ordering of the GROUP-BY expression to match ORDER-BY and it works! This will offcourse only work if the GROUP-BY and ORDER-BY matches generally expect for the direction. This fix only improves performance for relevant