Re: [sqlite] Bad implementation in mem5.c memsys5Roundup method in the latest version 3.25.0

2018-08-09 Thread David Yip
Do you have a benchmark demonstrating that time taken in memsys5Roundup is a bottleneck on some compiler and platform? gcc and clang both turn for(iFullSz=mem5.szAtom; iFullSz wrote: > We can increase the efficiency with the following code replace: > > > > > static int memsys5Roundup(int n){//cha

[sqlite] Bad implementation in mem5.c memsys5Roundup method in the latest version 3.25.0

2018-08-09 Thread 2009110205
We can increase the efficiency with the following code replace: static int memsys5Roundup(int n){//changed by wjf if( n > 0x4000 ) return 0; int i = 0; while (_BlockSize[i++] 0x4000 ) return 0; //for(iFullSz=mem5.szAtom; iFullSzmem5.szAtom ){ mem5.szAtom = mem5.szAto

[sqlite] Bad implementation in mem5.c memsys5Roundup method in the latest version 3.25.0

2018-08-09 Thread 2009110205
We can increase the efficiency with the following code replace: static int memsys5Roundup(int n){//changed by wjf if( n > 0x4000 ) return 0; int i = 0; while (_BlockSize[i++] 0x4000 ) return 0; //for(iFullSz=mem5.szAtom; iFullSzmem5.szAtom ){ mem5.szAtom = mem5.szAto