Re: [sqlite] Bug: SQLite shell does not build on Windows with SQLITE_OMIT_COMPLETE

2018-11-16 Thread Victor Costan
Thank you very much, Dan! I was about to come back to report that my fix is incorrect. Your fix does the trick. Thank you! Victor On Fri, Nov 16, 2018 at 6:38 AM Dan Kennedy wrote: > On 11/16/2018 08:41 PM, Victor Costan wrote: > > The amalgamation build ships two definitions of

Re: [sqlite] Bug: SQLite shell does not build on Windows with SQLITE_OMIT_COMPLETE

2018-11-16 Thread Dan Kennedy
On 11/16/2018 08:41 PM, Victor Costan wrote: The amalgamation build ships two definitions of sqlite3_complete(). Most builds use the one in sqlite3.c. If SQLITE_OMIT_COMPLETE is defined, shell.c supplies a stub definition -- thank you very much for adding that! Unfortunately, the stub

[sqlite] Bug: SQLite shell does not build on Windows with SQLITE_OMIT_COMPLETE

2018-11-16 Thread Victor Costan
The amalgamation build ships two definitions of sqlite3_complete(). Most builds use the one in sqlite3.c. If SQLITE_OMIT_COMPLETE is defined, shell.c supplies a stub definition -- thank you very much for adding that! Unfortunately, the stub definition in shell.c does not have the SQLITE_API