Re: [sqlite] EXTERNAL:Re: SQLite version 3.7.5 - code freeze

2011-01-25 Thread Dan Kennedy
On 01/25/2011 07:30 PM, Black, Michael (IS) wrote: > Yes -- MSVC spits out a bunch of constant expression warnings. Most are > bogus (e.g. while (1)). I looked at them all. > > In this case if it's a compile-time option (which it is) wouldn't you > normally put it in an #if block? Normally. But

Re: [sqlite] EXTERNAL:Re: SQLite version 3.7.5 - code freeze

2011-01-25 Thread Black, Michael (IS)
Yes -- MSVC spits out a bunch of constant expression warnings. Most are bogus (e.g. while (1)). I looked at them all. In this case if it's a compile-time option (which it is) wouldn't you normally put it in an #if block? It confused me when looking at the code as one or the other block will nev

Re: [sqlite] EXTERNAL:Re: SQLite version 3.7.5 - code freeze

2011-01-24 Thread Black, Michael (IS)
Oops...sorry...I copied it from 3.7.3 The line in 3.7.5 is at 55937: SQLITE_PRIVATE void sqlite3VdbeChangeP2(Vdbe *p, int addr, int val){ assert( p!=0 ); assert( addr>=0 ); if( p->nOp>addr ){ <<< Warning occurs here p->aOp[addr].p2 = val; } } A newer gcc with -O2 or highe

Re: [sqlite] EXTERNAL:Re: SQLite version 3.7.5 - code freeze

2011-01-24 Thread Black, Michael (IS)
I know some of these may seem minor but for those of us who turn on all warnings disabling them or explicitly allowing for them would prevent some of us from having to waste our time looking at them. Around line 59981 an explicit cast to u16 would prevent a loss-of-precision warning. And would