Re: [sqlite] Fixing some valgrind issues

2012-10-17 Thread Alfred Sawaya
calloc is C89 and C99. Is there any problem using it in sqlite ? 2012/10/17 Richard Hipp > On Wed, Oct 17, 2012 at 4:33 PM, Alfred Sawaya wrote: > > > Hello, > > > > > > Sqlite has some minor valgrind issues (some memory area point to > > unitialized bytes). >

Re: [sqlite] Fixing some valgrind issues

2012-10-17 Thread Richard Hipp
On Wed, Oct 17, 2012 at 4:33 PM, Alfred Sawaya wrote: > Hello, > > > Sqlite has some minor valgrind issues (some memory area point to > unitialized bytes). > You can easily avoid this by replacing malloc by calloc in src/mem1.c:84 > and src/mem2.c:255 > > Is it possible to

Re: [sqlite] Fixing some valgrind issues

2012-10-17 Thread Alfred Sawaya
It is not related to a particular SQL request. And the errors are corrected by using calloc instead of malloc in mem1.c and mem2.c Maybe sqlite team prefer to let the caller memset the allocated area ? Anyway, For this one : ==32575== Conditional jump or move depends on uninitialised value(s)

Re: [sqlite] Fixing some valgrind issues

2012-10-17 Thread Richard Hipp
On Wed, Oct 17, 2012 at 5:18 PM, Alfred Sawaya wrote: > The list block big messages... > > Here is a pastebin : http://pastebin.com/raw.php?i=QjN18m4h > Can you show us what SQL you are running in order to get these errors? > > 2012/10/17 Richard Hipp > > >

Re: [sqlite] Fixing some valgrind issues

2012-10-17 Thread Alfred Sawaya
The list block big messages... Here is a pastebin : http://pastebin.com/raw.php?i=QjN18m4h 2012/10/17 Richard Hipp > On Wed, Oct 17, 2012 at 4:56 PM, Alfred Sawaya wrote: > > > I send you the valgrind report, in attached file. > > > > This mailing list deletes

Re: [sqlite] Fixing some valgrind issues

2012-10-17 Thread Richard Hipp
On Wed, Oct 17, 2012 at 4:56 PM, Alfred Sawaya wrote: > I send you the valgrind report, in attached file. > This mailing list deletes attachments. Please include the valgrind report inline. Thanks. > > I use sqlite with sqlcipher but it is not a sqlcipher related issue I

Re: [sqlite] Fixing some valgrind issues

2012-10-17 Thread Alfred Sawaya
I send you the valgrind report, in attached file. I use sqlite with sqlcipher but it is not a sqlcipher related issue I think (please see the sqlcipher team reply : https://github.com/sqlcipher/sqlcipher/issues/33 ). Thank you. 2012/10/17 Richard Hipp > On Wed, Oct 17, 2012

Re: [sqlite] Fixing some valgrind issues

2012-10-17 Thread Richard Hipp
On Wed, Oct 17, 2012 at 4:36 PM, Richard Hipp wrote: > > > On Wed, Oct 17, 2012 at 4:33 PM, Alfred Sawaya wrote: > >> Hello, >> >> >> Sqlite has some minor valgrind issues (some memory area point to >> unitialized bytes). >> > > Really? We run many of our test

Re: [sqlite] Fixing some valgrind issues

2012-10-17 Thread Richard Hipp
On Wed, Oct 17, 2012 at 4:33 PM, Alfred Sawaya wrote: > Hello, > > > Sqlite has some minor valgrind issues (some memory area point to > unitialized bytes). > Really? We run many of our test cases here through valgrind and don't see any problems. Can you be more specific? >

[sqlite] Fixing some valgrind issues

2012-10-17 Thread Alfred Sawaya
Hello, Sqlite has some minor valgrind issues (some memory area point to unitialized bytes). You can easily avoid this by replacing malloc by calloc in src/mem1.c:84 and src/mem2.c:255 Is it possible to integrate those improvements into the mainline of Sqlite ? Thank you, Alfred. --