[sqlite] Re: make test fails for 32bit integers (-DSQLITE_INT64_TYPE=int -DSQLITE_32BIT_ROWID=1)

2006-11-28 Thread Steffen Gutmann
I have submitted it as ticket #2089 and named it "decoupling sqlite_int64 from other 64 bit datatypes". I also made another few changes and now make test reports even fewer errors than before (attached in the ticket). The only cases it fails are when using big files and when the integer values do

Re: [sqlite] Re: make test fails for 32bit integers (-DSQLITE_INT64_TYPE=int -DSQLITE_32BIT_ROWID=1)

2006-11-27 Thread Joe Wilson
Nice job decoupling the 8-byte double serialization logic from relying on 64 bit integers. Please consider creating an SQLite ticket for you patch so it might be incorporated into the official source tree. I must confess that I did not read the original 32-bit port thread URL in your first pos

[sqlite] Re: make test fails for 32bit integers (-DSQLITE_INT64_TYPE=int -DSQLITE_32BIT_ROWID=1)

2006-11-26 Thread Steffen Gutmann
Joe, thanks for the prompt reply. the detailed answers and your testing. I also had a closer look into the source and found some suggestions for myself... First of all, I completely agree that defining an 'int' as SQLITE_INT64_TYPE seems broken. It wasn't actually my idea but since it was propse