Re: [sqlite] possible buffer over-read in sqlite3VXPrintf()

>> Shouldn't escarg[] contain a nul-terminated string? > > Yes, I wondered that too when I looked at it again later. In which > case the code ought to be safe. > But if it's true that escarg[] should always be a nul-terminated > string (are you confident of this? I haven't studied the code

Re: [sqlite] possible buffer over-read in sqlite3VXPrintf()

Dan Kennedy wrote: > > On Mar 2, 2010, at 6:54 PM, Jonathan Kew wrote: > > > I've run into what appears to be a small bug in this function (from > > sqlite3.c, v 3.6.22). Suggested patch: [snip] > > > > The issue here is that when k reaches zero, the access to escarg[i] > > may try to look o

Re: [sqlite] possible buffer over-read in sqlite3VXPrintf()

On Mar 2, 2010, at 6:54 PM, Jonathan Kew wrote: > I've run into what appears to be a small bug in this function (from > sqlite3.c, v 3.6.22). Suggested patch: > > diff --git a/sqlite3.c b/sqlite3.c > --- a/sqlite3.c > +++ b/sqlite3.c > @@ -16938,17 +16938,17 @@ SQLITE_PRIVATE void sqlite3VXPrin

[sqlite] possible buffer over-read in sqlite3VXPrintf()

I've run into what appears to be a small bug in this function (from sqlite3.c, v 3.6.22). Suggested patch: diff --git a/sqlite3.c b/sqlite3.c --- a/sqlite3.c +++ b/sqlite3.c @@ -16938,17 +16938,17 @@ SQLITE_PRIVATE void sqlite3VXPrintf( int i, j, k, n, isnull; int needQuote;