[sqlite] sqldiff.c : 2 benign warnings in 64 bits builds

2016-01-26 Thread Stephan Beal
On Tue, Jan 26, 2016 at 6:40 PM, Scott Robison wrote: > On Tue, Jan 26, 2016 at 8:21 AM, Stephan Beal > wrote: > > fwiw, in case this matters: size_t has an unspecified size and it's not > in > > C89. It's defined by C99 in stddef.h > > > > size_t (and ptrdiff_t) are both in C89/C90 in

[sqlite] sqldiff.c : 2 benign warnings in 64 bits builds

2016-01-26 Thread Stephan Beal
On Tue, Jan 26, 2016 at 3:47 PM, J Decker wrote: > should be (size_t) instead of (int) though... since size_t will retain > the precision... and then back propagate the change to the function > return type and the things receiving the return... then you don't need > the cast anyway. > fwiw, in

[sqlite] sqldiff.c : 2 benign warnings in 64 bits builds

2016-01-26 Thread Olivier Mascia
Hello, Using (3.10.2), as was the case with 3.10.0, there are two warnings (VS.2015 at least, /W3 only) compiling in 64 bits: sqldiff.c(997): warning C4244: 'return': conversion from '__int64' to 'int', possible loss of data sqldiff.c(1144): warning C4244: 'return': conversion from '__int64'

[sqlite] sqldiff.c : 2 benign warnings in 64 bits builds

2016-01-26 Thread Scott Robison
On Tue, Jan 26, 2016 at 8:21 AM, Stephan Beal wrote: > On Tue, Jan 26, 2016 at 3:47 PM, J Decker wrote: > > > should be (size_t) instead of (int) though... since size_t will retain > > the precision... and then back propagate the change to the function > > return type and the things receiving

[sqlite] sqldiff.c : 2 benign warnings in 64 bits builds

2016-01-26 Thread J Decker
should be (size_t) instead of (int) though... since size_t will retain the precision... and then back propagate the change to the function return type and the things receiving the return... then you don't need the cast anyway. On Tue, Jan 26, 2016 at 3:37 AM, Richard Hipp wrote: > On 1/26/16,

[sqlite] sqldiff.c : 2 benign warnings in 64 bits builds

2016-01-26 Thread Richard Hipp
On 1/26/16, Olivier Mascia wrote: > Hello, > > Using (3.10.2), as was the case with 3.10.0, there are two warnings (VS.2015 > at least, /W3 only) compiling in 64 bits: > Fixed 12 days ago on trunk. https://www.sqlite.org/src/info/74808a79ea3194f6 -- D. Richard Hipp drh at sqlite.org

[sqlite] sqldiff.c : 2 benign warnings in 64 bits builds

2016-01-14 Thread Olivier Mascia
Hello, May I suggest to patch sqldiff.c (3.10.0) on lines 997 and 1144 as this: return (int)(zDelta - zOrigDelta); instead of: return zDelta - zOrigDelta; to suppress the benign warning about __int64 being converted to int which some compilers can emit because the difference of two