Re: [sqlite] [PATCH] Verify number of arguments in icuRegexpFunc

[Dan Kennedy]

On Jul 30, 2010, at 12:44 PM, Scott Hess wrote:

> On Thu, Jul 29, 2010 at 10:05 PM, Dan Kennedy  
>  wrote:
>> On Jul 30, 2010, at 8:39 AM, Paweł Hajdan, Jr. wrote:
>>> I'm attaching a suggested patch to verify number of arguments
>>> in icuRegexpFunc. Please review it.
>>>
>>> This is upstreaming of
>>> http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/icu-regexp.patch?revision=34807=markup
>>>
>>> According to the commit message from above, it has been reported
>>> earlier to
>>> you.
>>
>> How do you cause the error that this patch corrects?
>>
>> It looks like the regex function is registered so that
>> SQLite will only ever call it with exactly two arguments.
>
> The registration below is:
>{"regexp",-1, SQLITE_ANY,  0, icuRegexpFunc},
> Doesn't that imply that you could call regexp() or regexp("s")?

Looks like it was fixed for 3.6.22:

   http://www.sqlite.org/src/ci/c34cf23efb

Dan.

___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] [PATCH] Verify number of arguments in icuRegexpFunc

[Scott Hess]

On Thu, Jul 29, 2010 at 10:05 PM, Dan Kennedy  wrote:
> On Jul 30, 2010, at 8:39 AM, Paweł Hajdan, Jr. wrote:
>> I'm attaching a suggested patch to verify number of arguments
>> in icuRegexpFunc. Please review it.
>>
>> This is upstreaming of
>> http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/icu-regexp.patch?revision=34807=markup
>>
>> According to the commit message from above, it has been reported
>> earlier to
>> you.
>
> How do you cause the error that this patch corrects?
>
> It looks like the regex function is registered so that
> SQLite will only ever call it with exactly two arguments.

The registration below is:
{"regexp",-1, SQLITE_ANY,  0, icuRegexpFunc},
Doesn't that imply that you could call regexp() or regexp("s")?

-scott
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] [PATCH] Verify number of arguments in icuRegexpFunc

[Dan Kennedy]

On Jul 30, 2010, at 8:39 AM, Paweł Hajdan, Jr. wrote:

> I'm attaching a suggested patch to verify number of arguments
> in icuRegexpFunc. Please review it.
>
> This is upstreaming of
> http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/icu-regexp.patch?revision=34807=markup
>
> According to the commit message from above, it has been reported  
> earlier to
> you.

How do you cause the error that this patch corrects?

It looks like the regex function is registered so that
SQLite will only ever call it with exactly two arguments.


___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] problems with running test suite

[Gerry Snyder]

package require Tcl 8.5

is all it takes


Gerry

On 7/29/10, Richard Hipp  wrote:
> On Thu, Jul 29, 2010 at 4:44 PM, Paweł Hajdan, Jr.
> wrote:
>
>> I'm planning to contribute some patches (upstreaming patches Chromium
>> project applies to its local copy of sqlite).
>>
>> I've checked out the fossil repository, configured and compiled sqlite,
>> and
>> tried running "make test" (I didn't make any changes).
>>
>> I'm pasting below the test result and some fossil info. Please let me know
>> if you need more. This is on Ubuntu Lucid. Do you have any ideas what
>> makes
>> these tests fail? Should I be doing it some other way?
>>
>> wal2-10.2.1... Ok
>> wal2-10.2.2... Ok
>> wal2-10.2.3... Ok
>> wal2-11.0... Ok
>> wal2-11.1.1... Ok
>> ./testfixture: bad field specifier "t"
>>while executing
>>
>
>
> The test suite now requires Tcl 8.5.  You appear to be running Tcl 8.4.
>
> It would be relatively easy for use to enhance the test suite so that it
> automatically detects a too-old version of Tcl and prints a warning or
> error.  We'll try to make that change for you soon.
>
> --
> -
> D. Richard Hipp
> d...@sqlite.org
> ___
> sqlite-users mailing list
> sqlite-users@sqlite.org
> http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
>

-- 
Sent from my mobile device
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

[sqlite] [PATCH] Verify number of arguments in icuRegexpFunc

[Paweł Hajdan , Jr .]

I'm attaching a suggested patch to verify number of arguments
in icuRegexpFunc. Please review it.

This is upstreaming of
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/icu-regexp.patch?revision=34807=markup

According to the commit message from above, it has been reported earlier to
you.
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] problems with running test suite

[Simon Slavin]

On 30 Jul 2010, at 1:14am, Paweł Hajdan, Jr. wrote:

> On Thu, Jul 29, 2010 at 16:34, Richard Hipp  wrote:
> 
>> The test suite now requires Tcl 8.5.  You appear to be running Tcl 8.4.
>> 
> 
> That's right. After upgrading from tcl8.4 to tcl8.5 the tests run just fine.

Can you insert a new test, right at the beginning, that checks to see you're 
running a sufficiently high version of tcl ?

Simon.
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

[sqlite] Statistics on integer primary key

[Peter.Hizalev]

Hello,

Consider two tables:

> create table a(num integer primary key);
> create table b(num integer primary key);

After loading both tables we have 100 rows in table a and 1000 in table b. 
We make sure b.num is a subset of a.num. Now we execute:

> analyze

We run two queries with timer on:

> select count(*) from a join b using(num);
> select count(*) from b join a using(num);

Both queries return 1000, the 'a join b' takes 0.5 and 'b join a' 0.0. SQLite 
planner does not reorder join in first query to take advantage of smaller 
cardinality of b. The reason seems to be that there is no statistics collected 
for num column index, which is an alias for rowid b-tree. After adding explicit 
indexes on a(num) and b(num) and analyzing the database both queries take 0.0.

Why SQLite does not maintain statistics for rowid indexes?

Cheers,
Peter.
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] problems with running test suite

[Paweł Hajdan , Jr .]

On Thu, Jul 29, 2010 at 16:34, Richard Hipp  wrote:

> The test suite now requires Tcl 8.5.  You appear to be running Tcl 8.4.
>

That's right. After upgrading from tcl8.4 to tcl8.5 the tests run just fine.

Thanks!
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] problems with running test suite

[Richard Hipp]

On Thu, Jul 29, 2010 at 4:44 PM, Paweł Hajdan, Jr.
wrote:

> I'm planning to contribute some patches (upstreaming patches Chromium
> project applies to its local copy of sqlite).
>
> I've checked out the fossil repository, configured and compiled sqlite, and
> tried running "make test" (I didn't make any changes).
>
> I'm pasting below the test result and some fossil info. Please let me know
> if you need more. This is on Ubuntu Lucid. Do you have any ideas what makes
> these tests fail? Should I be doing it some other way?
>
> wal2-10.2.1... Ok
> wal2-10.2.2... Ok
> wal2-10.2.3... Ok
> wal2-11.0... Ok
> wal2-11.1.1... Ok
> ./testfixture: bad field specifier "t"
>while executing
>


The test suite now requires Tcl 8.5.  You appear to be running Tcl 8.4.

It would be relatively easy for use to enhance the test suite so that it
automatically detects a too-old version of Tcl and prints a warning or
error.  We'll try to make that change for you soon.

-- 
-
D. Richard Hipp
d...@sqlite.org
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

[sqlite] problems with running test suite

[Paweł Hajdan , Jr .]

I'm planning to contribute some patches (upstreaming patches Chromium
project applies to its local copy of sqlite).

I've checked out the fossil repository, configured and compiled sqlite, and
tried running "make test" (I didn't make any changes).

I'm pasting below the test result and some fossil info. Please let me know
if you need more. This is on Ubuntu Lucid. Do you have any ideas what makes
these tests fail? Should I be doing it some other way?

wal2-10.2.1... Ok
wal2-10.2.2... Ok
wal2-10.2.3... Ok
wal2-11.0... Ok
wal2-11.1.1... Ok
./testfixture: bad field specifier "t"
while executing
"binary scan $I t* L"
(file "./test/wal2.test" line 987)
invoked from within
"source ./test/wal2.test"
invoked from within
"interp eval tinterp $script"
(procedure "slave_test_script" line 24)
invoked from within
"slave_test_script [list source $zFile] "
invoked from within
"time { slave_test_script [list source $zFile] }"
(procedure "slave_test_file" line 14)
invoked from within
"slave_test_file $::testdir/$file"
(procedure "run_tests" line 12)
invoked from within
"run_tests veryquick -presql {} -files {shared3.test bigfile.test
where9.test tkt3419.test sync.test fts1o.test fts2f.test misc2.test
tkt3541.test type..."
("uplevel" body line 1)
invoked from within
"uplevel run_tests $name $::testspec($name)"
(procedure "run_test_suite" line 5)
invoked from within
"run_test_suite veryquick"
(file "./test/veryquick.test" line 16)
make: *** [test] Error 1

real 12m54.106s
user 1m21.060s
sys 0m52.890s

$ fossil status
repository:   /home/phajdan/sqlite/sqlite.fossil
local-root:   /home/phajdan/sqlite/
server-code:  56e02465c398e67515e94b1e1be0a6a41f357093
checkout: 33b1e862ffa7109480cf4a77ceae8aebe98d3eee 2010-07-28 19:17:51
UTC
parent:   a3401d9ee540828f3efd26d89f6b771e0ecb2777 2010-07-28 18:51:27
UTC
tags: trunk

$ fossil timeline
=== 2010-07-28 ===
13:57:49 [4202cdf359] New ticket [ce7c133ea6] Foreign key constraint
fails
 when it should succeed.. (user: drh)
12:17:51 [33b1e862ff] *CURRENT* Get SQLITE_OMIT_VIRTUALTABLE working again
 after being broken by recent changes. (user: drh tags: trunk)
11:51:27 [a3401d9ee5] Fix the dbstatus.test script so that it works
correctly
 on 64-bit machines. (user: drh tags: trunk)
11:35:50 [aa81900153] *MERGE* Merge trunk changes into experimental branch.
 (user: dan tags: experimental)
10:36:12 [ae89777e7f] Improve the accuracy of the Pager heap usage estimate.
 (user: drh tags: trunk)
10:16:41 [2f2fa7dd80] Adjust the shell test script "shell4.test" to account
 for changes in the ".stat on" display format from the previous
 checkin. (user: drh tags: trunk)
10:01:24 [f9adf66ad5] Record the pcache allocation size statistics even for
 pcache overflow allocations. Adjust the wording on one of the stat
 output lines in the shell. (user: drh tags: trunk)
09:05:35 [419ce0ed89] Modify CLI to optionally display "stats". (user:
shaneh
 tags: trunk)
08:52:09 [07abfd5268] Lookaside memory is not used to store schemas. Change
 the SQLITE_DBSATUS_SCHEMA_USED documentation to reflect this fact.
 (user: drh tags: trunk)
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] typo in src/os_os2.c

[Richard Hipp]

On Wed, Jul 28, 2010 at 4:46 PM, Tamas TEVESZ  wrote:

>
> hello,
>
> diff says it all:
>
> -  OSTRACE( "OPEN want %d\n", flags ));
> +  OSTRACE(( "OPEN want %d\n", flags ));
>
>


Previously found and fixed here:  http://www.sqlite.org/src/ci/a6bb2108bf

Do you have an OS/2 compile capability?  The SQLite developers do not.  We
would appreciate your assistance in testing SQLite on OS/2.  If you can
download periodic development snapshots from
http://www.sqlite.org/draft/download.html and test them on OS/2 and alert us
to any problems you find, that would be very helpful.  Thanks!


-- 
-
D. Richard Hipp
d...@sqlite.org
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

[sqlite] typo in src/os_os2.c

[Tamas TEVESZ]

hello,

diff says it all:

diff -urN sqlite-3.7.0.orig/src/os_os2.c sqlite-3.7.0/src/os_os2.c
--- sqlite-3.7.0.orig/src/os_os2.c  2010-07-18 21:30:41.0 
+0200
+++ sqlite-3.7.0/src/os_os2.c   2010-07-28 22:34:26.784414844 +0200
@@ -779,7 +779,7 @@
 
   memset( pFile, 0, sizeof(*pFile) );
 
-  OSTRACE( "OPEN want %d\n", flags ));
+  OSTRACE(( "OPEN want %d\n", flags ));
 
   if( flags & SQLITE_OPEN_READWRITE ){
 ulOpenMode |= OPEN_ACCESS_READWRITE;


thanks,

-- 
[-]

mkdir /nonexistent
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users