Hi,
I would like to report two compiler warnings when compiling v3.7.11 with
Embedded Visaul C++ 4.0 for Windows Mobile devices:
- sqlite3.c, line 68356, code "u.bb.r.flags = (u16)(UNPACKED_INCRKEY *
(1 & (u.bb.oc - OP_SeekLt)));" causes compiler warning "warning C4244:
'=' : conversion from 'unsigned short ' to 'unsigned char ', possible
loss of data". As I see loss of data is not possible, but still I
suggest code replacement with "u.bb.r.flags = (u8)(UNPACKED_INCRKEY *
(1 & (u.bb.oc - OP_SeekLt)));". As I checked it's more correct.
- sqlite3.c, line 21434, code "result = 1e308*1e308*s; /* Infinity */"
causes compiler warning "warning C4056: overflow in floating-point
constant arithmetic". As I see Visual Studio 2010 doesn't give warning
for this case, so I guess there should be some kind of define for
maksimum value, instead of hard coded value (DBL_MAX maybe?). Different
systems can have different maxsimum values.
--
Lep pozdrav / Best regards
Bostjan Erzen
ERPO SISTEMI d.o.o.
Britof 94, 4000 Kranj, Slovenia
WWW: http://www.erpo-sistemi.si
Tel. : +386 41 386 680
_______________________________________________
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
