Re: [sqlite] [PATCH] Verify number of arguments in icuRegexpFunc

[Paweł Hajdan , Jr .]

On Thu, Jul 29, 2010 at 22:53, Dan Kennedy  wrote:

> Looks like it was fixed for 3.6.22:
>
>   http://www.sqlite.org/src/ci/c34cf23efb


Thank you. I have changed chromium's copy of sqlite to contain the above
version of the code, so we're closer to upstream now.
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] [PATCH] Verify number of arguments in icuRegexpFunc

[Scott Hess]

Ah, OK (I was finding an older different version on the sqlite.org site).

Pawel, we could probably modify our patch to use SQLite's change, then
on next merge it will go away.

Thanks,
scott


On Thu, Jul 29, 2010 at 10:53 PM, Dan Kennedy  wrote:
>
> On Jul 30, 2010, at 12:44 PM, Scott Hess wrote:
>
>> On Thu, Jul 29, 2010 at 10:05 PM, Dan Kennedy
>>  wrote:
>>> On Jul 30, 2010, at 8:39 AM, Paweł Hajdan, Jr. wrote:
 I'm attaching a suggested patch to verify number of arguments
 in icuRegexpFunc. Please review it.

 This is upstreaming of
 http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/icu-regexp.patch?revision=34807=markup

 According to the commit message from above, it has been reported
 earlier to
 you.
>>>
>>> How do you cause the error that this patch corrects?
>>>
>>> It looks like the regex function is registered so that
>>> SQLite will only ever call it with exactly two arguments.
>>
>> The registration below is:
>>    {"regexp",-1, SQLITE_ANY,          0, icuRegexpFunc},
>> Doesn't that imply that you could call regexp() or regexp("s")?
>
> Looks like it was fixed for 3.6.22:
>
>   http://www.sqlite.org/src/ci/c34cf23efb
>
> Dan.
>
> ___
> sqlite-users mailing list
> sqlite-users@sqlite.org
> http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users
>
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] [PATCH] Verify number of arguments in icuRegexpFunc

[Dan Kennedy]

On Jul 30, 2010, at 12:44 PM, Scott Hess wrote:

> On Thu, Jul 29, 2010 at 10:05 PM, Dan Kennedy  
>  wrote:
>> On Jul 30, 2010, at 8:39 AM, Paweł Hajdan, Jr. wrote:
>>> I'm attaching a suggested patch to verify number of arguments
>>> in icuRegexpFunc. Please review it.
>>>
>>> This is upstreaming of
>>> http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/icu-regexp.patch?revision=34807=markup
>>>
>>> According to the commit message from above, it has been reported
>>> earlier to
>>> you.
>>
>> How do you cause the error that this patch corrects?
>>
>> It looks like the regex function is registered so that
>> SQLite will only ever call it with exactly two arguments.
>
> The registration below is:
>{"regexp",-1, SQLITE_ANY,  0, icuRegexpFunc},
> Doesn't that imply that you could call regexp() or regexp("s")?

Looks like it was fixed for 3.6.22:

   http://www.sqlite.org/src/ci/c34cf23efb

Dan.

___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] [PATCH] Verify number of arguments in icuRegexpFunc

[Scott Hess]

On Thu, Jul 29, 2010 at 10:05 PM, Dan Kennedy  wrote:
> On Jul 30, 2010, at 8:39 AM, Paweł Hajdan, Jr. wrote:
>> I'm attaching a suggested patch to verify number of arguments
>> in icuRegexpFunc. Please review it.
>>
>> This is upstreaming of
>> http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/icu-regexp.patch?revision=34807=markup
>>
>> According to the commit message from above, it has been reported
>> earlier to
>> you.
>
> How do you cause the error that this patch corrects?
>
> It looks like the regex function is registered so that
> SQLite will only ever call it with exactly two arguments.

The registration below is:
{"regexp",-1, SQLITE_ANY,  0, icuRegexpFunc},
Doesn't that imply that you could call regexp() or regexp("s")?

-scott
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

Re: [sqlite] [PATCH] Verify number of arguments in icuRegexpFunc

[Dan Kennedy]

On Jul 30, 2010, at 8:39 AM, Paweł Hajdan, Jr. wrote:

> I'm attaching a suggested patch to verify number of arguments
> in icuRegexpFunc. Please review it.
>
> This is upstreaming of
> http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/icu-regexp.patch?revision=34807=markup
>
> According to the commit message from above, it has been reported  
> earlier to
> you.

How do you cause the error that this patch corrects?

It looks like the regex function is registered so that
SQLite will only ever call it with exactly two arguments.


___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users

[sqlite] [PATCH] Verify number of arguments in icuRegexpFunc

[Paweł Hajdan , Jr .]

I'm attaching a suggested patch to verify number of arguments
in icuRegexpFunc. Please review it.

This is upstreaming of
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/icu-regexp.patch?revision=34807=markup

According to the commit message from above, it has been reported earlier to
you.
___
sqlite-users mailing list
sqlite-users@sqlite.org
http://sqlite.org:8080/cgi-bin/mailman/listinfo/sqlite-users