Re: [SQLObject] Reconnect to MySQL

2007-03-06 Thread Oleg Broytmann
On Tue, Mar 06, 2007 at 06:59:33PM +0100, Markus Gritsch wrote: > >if MySQLdb.version_info[:3] > (1, 2, 1) > > Ah, nice. Didn't know that works. Python is the best language! > There is a similar check in > mysqlconnection.py around line 31. Already fixed, of course. Oleg. --

Re: [SQLObject] Reconnect to MySQL (was: Regression in SQLObject 0.8.0b1)

2007-03-06 Thread Markus Gritsch
On 3/6/07, Oleg Broytmann <[EMAIL PROTECTED]> wrote: > On Tue, Mar 06, 2007 at 02:59:11PM +0100, Markus Gritsch wrote: > > MySQLdb 1.2.2 has just been released on Saturday, and it allows > > setting the reconnect flag. I made some changes to mysqlconnection.py > > to support this. Please find the

Re: [SQLObject] Reconnect to MySQL (was: Regression in SQLObject 0.8.0b1)

2007-03-06 Thread Oleg Broytmann
On Tue, Mar 06, 2007 at 02:59:11PM +0100, Markus Gritsch wrote: > MySQLdb 1.2.2 has just been released on Saturday, and it allows > setting the reconnect flag. I made some changes to mysqlconnection.py > to support this. Please find the patch attached. Applied in the revisions 2396-2399 (0.7,

Re: [SQLObject] Reconnect to MySQL (was: Regression in SQLObject 0.8.0b1)

2007-03-06 Thread Oleg Broytmann
On Tue, Mar 06, 2007 at 02:59:11PM +0100, Markus Gritsch wrote: > MySQLdb 1.2.2 has just been released on Saturday, and it allows > setting the reconnect flag. I made some changes to mysqlconnection.py > to support this. Please find the patch attached. Thank you! Will be applied. I think it's

Re: [SQLObject] Reconnect to MySQL (was: Regression in SQLObject 0.8.0b1)

2007-03-06 Thread Markus Gritsch
Hi, MySQLdb 1.2.2 has just been released on Saturday, and it allows setting the reconnect flag. I made some changes to mysqlconnection.py to support this. Please find the patch attached. Kind regards, Markus reconnect.patch Description: Binary data ---

Re: [SQLObject] Reconnect to MySQL

2007-01-17 Thread Oleg Broytmann
On Wed, Jan 17, 2007 at 12:06:11AM +0200, Dan Pascu wrote: > However I fail to see the point to reimplement all this logic in sqlobject > when it is already implemented by the mysql library. There are other backends beside MySQL. TurboGears people have reported they are having problems with Po

Re: [SQLObject] Reconnect to MySQL

2007-01-16 Thread sophana
Dan Pascu a écrit : > IMO, I see no reason why a server restart cannot be handled by the same > reconnect feature of the underlying mysql library. From the sqlobject > point of view the situation is the same, no matter if the connection did > timeout or the server was restarted. Once it timeouts

Re: [SQLObject] Reconnect to MySQL

2007-01-16 Thread Dan Pascu
On Tuesday 16 January 2007 17:35, Oleg Broytmann wrote: > On Tue, Jan 16, 2007 at 06:28:53PM +0300, Oleg Broytmann wrote: > > > Further, Dan had also some concerns about transactions. He wrote > > > that if the reconnectiong would happen at MySQLdb level, it could > > > be handled gracefully, but

Re: [SQLObject] Reconnect to MySQL

2007-01-16 Thread Dan Pascu
As I said before, this approach will mess transactions badly, as it can change the connection in the middle of a transaction and the caller will be unaware of this as there will be no indication of what happened. The reconnect feature that is implemented by the mysql client library knows if th

Re: [SQLObject] Reconnect to MySQL

2007-01-16 Thread Oleg Broytmann
On Tue, Jan 16, 2007 at 06:28:53PM +0300, Oleg Broytmann wrote: > > Further, Dan had also some concerns about transactions. He wrote that > > if the reconnectiong would happen at MySQLdb level, it could be > > handled gracefully, but that things will get messed up which the patch > > to SQLObject,

Re: [SQLObject] Reconnect to MySQL

2007-01-16 Thread Oleg Broytmann
On Tue, Jan 16, 2007 at 04:22:16PM +0100, Dr. Markus Gritsch wrote: > Sounds quite ok. And, BTW, there is an unexplored SolidConnection from DBUtil. I just remembered I have to look into it. > Still, have you any opinion about the pooling-stuff? It has to be preserved, I think. > Further,

Re: [SQLObject] Reconnect to MySQL

2007-01-16 Thread Dr. Markus Gritsch
On 1/16/07, Oleg Broytmann <[EMAIL PROTECTED]> wrote: > On Tue, Jan 16, 2007 at 03:53:39PM +0100, Dr. Markus Gritsch wrote: > > Unfortunately, I had to further modify the previous patch to get > > reconnected in all cases: The __init__ method of the Iteration class > > has also to use the hack. Fu

Re: [SQLObject] Reconnect to MySQL

2007-01-16 Thread Oleg Broytmann
On Tue, Jan 16, 2007 at 03:53:39PM +0100, Dr. Markus Gritsch wrote: > Unfortunately, I had to further modify the previous patch to get > reconnected in all cases: The __init__ method of the Iteration class > has also to use the hack. Further, due to my missing insight into the > inner workings of

Re: [SQLObject] Reconnect to MySQL (was: Regression in SQLObject 0.8.0b1)

2007-01-16 Thread Dr. Markus Gritsch
On 1/16/07, Oleg Broytmann <[EMAIL PROTECTED]> wrote: > On Sat, Dec 30, 2006 at 04:29:41PM +0100, Markus Gritsch wrote: > > Just FYI: I made a small hack to my local SQLObject which solves the > > reconnect problem for me without recompiling MySQLdb. The patch is > > attached, but as already said,

Re: [SQLObject] Reconnect to MySQL (was: Regression in SQLObject 0.8.0b1)

2007-01-16 Thread Dr. Markus Gritsch
On 1/16/07, Oleg Broytmann <[EMAIL PROTECTED]> wrote: On Sat, Dec 30, 2006 at 04:29:41PM +0100, Markus Gritsch wrote: > Just FYI: I made a small hack to my local SQLObject which solves the > reconnect problem for me without recompiling MySQLdb. The patch is > attached, but as already said, it's

Re: [SQLObject] Reconnect to MySQL (was: Regression in SQLObject 0.8.0b1)

2007-01-16 Thread Oleg Broytmann
On Sat, Dec 30, 2006 at 04:29:41PM +0100, Markus Gritsch wrote: > Just FYI: I made a small hack to my local SQLObject which solves the > reconnect problem for me without recompiling MySQLdb. The patch is > attached, but as already said, it's just a hack. Thanks to anyone > involved. Could tha