On 23/07/2015 3:32 a.m., Alex Rousskov wrote:
On 07/21/2015 04:25 AM, Amos Jeffries wrote:
On 21/07/2015 9:42 a.m., Alex Rousskov wrote:
adaptation_access icapS aclIcap
adaptation_access icapN !aclIcap
aclIcap can be a received_encrypted ACL. What ACL expression would you
suggest for
On 07/23/2015 11:11 AM, Amos Jeffries wrote:
Particular since the full fix is a one-liner in consumeTrailing() in
place of that comment, and currently affecting no other code that would
need auditing.
That one-liner being identical to the matching code in consume():
parsed_ +=
On 07/23/2015 01:41 PM, Tsantilas Christos wrote:
On 07/23/2015 07:21 PM, Alex Rousskov wrote:
Furthermore, the values of unsafe srcX enum constants should be
increased to actually match the srcUnsafe mask (16 is still smaller than
0x).
This is should be OK.
The safe flags are from:
Please note: most of my comments in this long email are informational.
Things which need to be taken into consideration when touching the parser.
Audit proper follows at the end.
I request performance testing of the final version of this change vs
lastest trunk at the time.
If possible an
On 07/23/2015 09:08 AM, Amos Jeffries wrote:
On 24/07/2015 1:55 a.m., Alex Rousskov wrote:
On 07/23/2015 01:46 AM, Kinkie wrote:
the only thing I don't understand is the XXX in
parsedSize(); it's not clear why the comment,
...
as soon as that's improved, +1.
Why?! This is not something
On 23/07/2015 10:41 a.m., Alex Rousskov wrote:
Hello,
The attached patch adds SBuf and Tokenizer methods to simplify
suffix parsing and skipping (and to make suffix/reverse APIs more
similar to prefix/forward ones). The new methods are used in another
patch (to be posted shortly) that
On 07/23/2015 07:41 AM, Amos Jeffries wrote:
On 23/07/2015 3:32 a.m., Alex Rousskov wrote:
On 07/21/2015 04:25 AM, Amos Jeffries wrote:
On 21/07/2015 9:42 a.m., Alex Rousskov wrote:
adaptation_access icapS aclIcap
adaptation_access icapN !aclIcap
aclIcap can be a received_encrypted ACL.
On 24/07/2015 4:45 a.m., Kinkie wrote:
On Thu, Jul 23, 2015 at 3:55 PM, Alex Rousskov
rouss...@measurement-factory.com wrote:
On 07/23/2015 01:46 AM, Kinkie wrote:
the only thing I don't understand is the XXX in
parsedSize(); it's not clear why the comment,
The parsedSize() method is
