Re: [squid-dev] bug 4303

2015-08-12 Thread Marcus Kool
Amos, I tried the patch but several hunks failed. It seems that the patch is not compatible with the 3.5.7 release code or I am doing something wrong (see below). Marcus [root@srv018 squid-3.5.7]# patch -b -p0 --dry-run ../squid-sslbump-patch checking file src/acl/Acl.h Hunk #1 succeeded at

Re: [squid-dev] [PATCH] Reject responses with conflicting Content-Length

2015-08-12 Thread Alex Rousskov
On 08/11/2015 11:49 PM, Amos Jeffries wrote: Which one of these malformations is not malign ? * non-numeric Content-Length * negative value Content-Length * Content-Length with also Transfer-Encoding header * multiple different-value Content-Length * Content-Length on 204 response

Re: [squid-dev] [CODE] iterating over enums

2015-08-12 Thread Kinkie
Hi Alex, it turns out that the itch is real, and this is actually going to be useful in carrying forward the HttpHeader restructuring I'm doing in lp:~kinkie/squid/coverity-fixes, to iterate over the list of header types for various purposes (compacting, etc). So I went ahead and just

Re: [squid-dev] [PATCH] suffix parsing and skipping

2015-08-12 Thread Alex Rousskov
On 08/07/2015 11:08 PM, Amos Jeffries wrote: +1. Looks great. Thank you. Committed to trunk (r14222). Alex. ___ squid-dev mailing list squid-dev@lists.squid-cache.org http://lists.squid-cache.org/listinfo/squid-dev

Re: [squid-dev] [PATCH] PayloadFormatter (was PackableStream)

2015-08-12 Thread Alex Rousskov
On 08/12/2015 06:28 AM, Amos Jeffries wrote: On 12/08/2015 5:07 a.m., Alex Rousskov wrote: On 08/10/2015 08:20 AM, Amos Jeffries wrote: Here is mk2 of the Formatter class for doing display things to CacheMgr report payloads. Please post the patch (your post had no attachments), preferably

[squid-dev] Jenkins build is back to normal : trunk-polygraph #813

2015-08-12 Thread noc
See http://build.squid-cache.org/job/trunk-polygraph/813/ ___ squid-dev mailing list squid-dev@lists.squid-cache.org http://lists.squid-cache.org/listinfo/squid-dev

Re: [squid-dev] squid-3.5.7 -- xstrerror missing

2015-08-12 Thread Amos Jeffries
On 12/08/2015 10:27 p.m., Amos Jeffries wrote: I think I've cracked this. Both the helpers mentioned so far are missing libmiscutil.la. Or not. Sorry, got a bit too excited looking at an older version. That code did move to libcompat-squid.la by 3.5.7. And your traces show that is being

Re: [squid-dev] [PATCH] Reject responses with conflicting Content-Length

2015-08-12 Thread Eliezer Croitoru
+1 on this. I noticed this couple times in couple sites that the '|' was parsed and I had to exception the cases of urls with '|' in them. Eliezer On 12/08/2015 08:49, Amos Jeffries wrote: Which reminds me, if you can get similar details about the AWS software breakage with '|' URI

Re: [squid-dev] squid-3.5.7 -- xstrerror missing

2015-08-12 Thread Amos Jeffries
I think I've cracked this. Both the helpers mentioned so far are missing libmiscutil.la. Amos ___ squid-dev mailing list squid-dev@lists.squid-cache.org http://lists.squid-cache.org/listinfo/squid-dev

Re: [squid-dev] [PATCH] PayloadFormatter (was PackableStream)

2015-08-12 Thread Amos Jeffries
On 12/08/2015 5:07 a.m., Alex Rousskov wrote: On 08/10/2015 08:20 AM, Amos Jeffries wrote: Here is mk2 of the Formatter class for doing display things to CacheMgr report payloads. Please post the patch (your post had no attachments), preferably reflecting the discussion that happened since

[squid-dev] bug 4303

2015-08-12 Thread Marcus Kool
yesterday I filed bug 4303 - assertion failed in PeerConnector:743 squid 3.5.7 I am not sure if it is a duplicate of bug 4259 since that bug description has almost no info to compare against. I enclosed a small fragment of cache.log in the bug report but the debug setting was ALL,1 93,3 61,9

Re: [squid-dev] bug 4303

2015-08-12 Thread Amos Jeffries
On 13/08/2015 12:48 a.m., Marcus Kool wrote: yesterday I filed bug 4303 - assertion failed in PeerConnector:743 squid 3.5.7 I am not sure if it is a duplicate of bug 4259 since that bug description has almost no info to compare against. I enclosed a small fragment of cache.log in the bug

Re: [squid-dev] [PATCH] Ignore impossible SSL bumping actions, as intended and documented / bug 4237 fix

2015-08-12 Thread Alex Rousskov
On 08/11/2015 10:40 AM, Amos Jeffries wrote: On 11/08/2015 11:24 p.m., Tsantilas Christos wrote: The reconnect is not yet implemented. Gah. So for the last year-ish it has been published in wiki SslPeekAndSplice page as an available config option. But is actually nothing more than an

Re: [squid-dev] [CODE] iterating over enums

2015-08-12 Thread Alex Rousskov
On 08/12/2015 09:36 AM, Kinkie wrote: So I went ahead and just implemented it, starting from your observations. It's a bit more complex that your proposal, as I took the chance to implement bidirectional forward and reverse iterators. The attached patch is in changeset 14235 of