On 01/22/2017 02:23 PM, Amos Jeffries wrote:
> On 22/01/2017 4:51 p.m., Alex Rousskov wrote:
>> On 01/21/2017 06:42 PM, Amos Jeffries wrote:
>>> -long DelayPools::MemoryUsed = 0;
>> The total provided by this global was probably quite handy/useful. If we
>> can compute and still print it in
On 02/02/2017 05:53 AM, Eduard Bagdasaryan wrote:
> I applied your polishing suggestions to my latest patch
> re-attached it.
> +std::vector AnyP::UriScheme::LowercaseSchemeNames;
> +static std::vector LowercaseSchemeNames;
We should avoid this code duplication:
typedef std::vector
On 02/01/2017 11:51 PM, Amos Jeffries wrote:
> Can we agree on this being a fundamental design in Squid:
>
> * all connections have an associated socket ID.
That assumption would be too limiting (and, AFAICT, unnecessary). For
example, SSL connections inside SSL connections (HTTPS proxy) do
Hello,
This patch fixes VIA appending code duplication, moving common
code into a separate method.
Regards,
Eduard.
Fixed appending Http::HdrType::VIA code duplication.
=== modified file 'src/HttpHeader.cc'
--- src/HttpHeader.cc 2017-01-25 22:29:03 +
+++ src/HttpHeader.cc 2017-02-02
I applied your polishing suggestions to my latest patch
re-attached it.
Eduard.
On 02.02.2017 11:33, Amos Jeffries wrote:
On 1/02/2017 2:18 a.m., Eduard Bagdasaryan wrote:
Optimized with static array as you suggested and
re-attached the patch.
Thank you, looks like this one removes most
On 02/02/2017 03:16 πμ, Alex Rousskov wrote:
On 02/01/2017 01:42 PM, Christos Tsantilas wrote:
must take in account that some openSSL calls
returns locket objects, and some other unlocked objects.
Does the patch start using shared pointers for any objects in the
second, "returned unlocked"
On 1/02/2017 2:18 a.m., Eduard Bagdasaryan wrote:
> Optimized with static array as you suggested and
> re-attached the patch.
>
Thank you, looks like this one removes most of the performance regression.
Just some polishing for src/anyp/UriScheme.cc ;
in AnyP::UriScheme::UriScheme
* this TODO