Re: [squid-dev] [PATCH] Response delay pools

2017-02-09 Thread Alex Rousskov
On 01/30/2017 04:43 PM, Eduard Bagdasaryan wrote: > Thanks for the detailed review. I tried to address all other remarks, > renamed parameters according to the suggested terminology, > merged with latest v5 r15027 and re-attached the patch. Amos, did Eduard address your concerns? Any other

Re: [squid-dev] [PATCH] Memory overlap Valgrind-reported errors

2017-02-09 Thread Amos Jeffries
On 17/01/2017 4:45 p.m., Amos Jeffries wrote: > On 16/01/2017 11:20 p.m., Eduard Bagdasaryan wrote: >> Thank you. >> Also I believe the same patch could be applied to v4 and v3.5 >> (with a little adjustment). Are you planning to do this? >> > > Yes, when I next do the backporting. > Which

Re: [squid-dev] [PATCH] VIA creation code duplication

2017-02-09 Thread Amos Jeffries
On 3/02/2017 4:02 a.m., Eduard Bagdasaryan wrote: > Hello, > > This patch fixes VIA appending code duplication, moving common > code into a separate method. > Since Via is a list header we should be able to just append a new Via header to the header list with putStr. No need to use getList,

Re: [squid-dev] [PATCH] Digest Auth support for LDAP HA1 attribute without realm

2017-02-09 Thread Amos Jeffries
On 7/02/2017 10:33 p.m., FUSTE Emmanuel wrote: > New patch attached. > - Empty realm parameter is treated as no realm parameter supplied. > - realm parameter is mandatory if empty delimiter is supplied > - -f vs -F typo corrected in the help text > Tested in real conditions. > Thanks. I have

Re: [squid-dev] [PATCH] Bump SSL client on [more] errors encountered before ssl_bump evaluation

2017-02-09 Thread Amos Jeffries
On 7/02/2017 11:12 p.m., Christos Tsantilas wrote: > On 07/02/2017 11:43 πμ, Amos Jeffries wrote: >> On 7/02/2017 6:07 a.m., Christos Tsantilas wrote: >>> Applied to trunk as r15036. >>> >>> I am attaching the patch for squid-3.5 >>> >>> >>> On 04/02/2017 04:07 μμ, Amos Jeffries wrote: On