Re: [squid-dev] [PATCH] VIA creation code duplication

2017-02-10 Thread Alex Rousskov
On 02/10/2017 04:17 PM, Amos Jeffries wrote: > This patch is "polishing a turd" as the saying goes and a bit premature. > There are some obvious and easy to fix bugs that should be attended > first, then polishing afterwards. I agree that there are many problems related to Via adding code and

Re: [squid-dev] [PATCH] VIA creation code duplication

2017-02-10 Thread Amos Jeffries
On 11/02/2017 5:04 a.m., Alex Rousskov wrote: > On 02/09/2017 10:19 AM, Amos Jeffries wrote: >> On 3/02/2017 4:02 a.m., Eduard Bagdasaryan wrote: >>> This patch fixes VIA appending code duplication, moving common >>> code into a separate method. > >> Since Via is a list header we should be able

Re: [squid-dev] [PATCH] VIA creation code duplication

2017-02-10 Thread Alex Rousskov
On 02/09/2017 10:19 AM, Amos Jeffries wrote: > On 3/02/2017 4:02 a.m., Eduard Bagdasaryan wrote: >> This patch fixes VIA appending code duplication, moving common >> code into a separate method. > Since Via is a list header we should be able to just append a new Via > header to the header list