Re: [squid-dev] [PATCH] Bug 4662 adding --with-libressl build option

2017-02-01 Thread Alex Rousskov
On 02/01/2017 08:20 AM, Marcus Kool wrote: >> Do you think we can compromise and call it USE_OPENSSL_OR_LIBRESSL ? > or call it USE_OPENSSL_API > > and then the code will eventually have none or few occurrences of > USE_OPENSSL and USE_LIBRESSL to deal with OpenSSL and LibreSSL specifics. Yes,

Re: [squid-dev] [PATCH] Bug 4662 adding --with-libressl build option

2017-02-01 Thread Alex Rousskov
Executive summary: * Still no agreement on whether or how to rename the primary SSL guard. * Possibly an agreement to continue using a single primary SSL guard?? * Clarification that --with-libressl itself is a relatively minor issue. * A firm veto on adding support for the 3rd SSL API. Whether

Re: [squid-dev] [PATCH] Bug 4662 adding --with-libressl build option

2017-02-01 Thread Marcus Kool
Do you think we can compromise and call it USE_OPENSSL_OR_LIBRESSL ? or call it USE_OPENSSL_API and then the code will eventually have none or few occurrences of USE_OPENSSL and USE_LIBRESSL to deal with OpenSSL and LibreSSL specifics. Marcus ___

Re: [squid-dev] [PATCH] Bug 4662 adding --with-libressl build option

2017-02-01 Thread Alex Rousskov
On 02/01/2017 05:00 AM, Eliezer Croitoru wrote: > I do believe that for the latest hardware with beefy CPU, code > repetition in C++ might not be much of a regression but not everybody > can replace their systems hardware every year. (If my assumption > about code repetition affecting older

Re: [squid-dev] [PATCH] Bug 4662 adding --with-libressl build option

2017-02-01 Thread Eliezer Croitoru
To: Squid Developers <squid-dev@lists.squid-cache.org> Subject: Re: [squid-dev] [PATCH] Bug 4662 adding --with-libressl build option On 01/31/2017 08:20 AM, Amos Jeffries wrote: > On 31/01/2017 7:04 a.m., Alex Rousskov wrote: >> On 01/29/2017 04:26 AM, Amos Jeffries wrote: >>> This

Re: [squid-dev] [PATCH] Bug 4662 adding --with-libressl build option

2017-01-31 Thread Alex Rousskov
On 01/31/2017 08:20 AM, Amos Jeffries wrote: > On 31/01/2017 7:04 a.m., Alex Rousskov wrote: >> On 01/29/2017 04:26 AM, Amos Jeffries wrote: >>> This is I think all we need to do code-wise to resolve the Bug 4662 >>> issues with LibreSSL being incompatible with OpenSSL 1.1. >> I do not think

Re: [squid-dev] [PATCH] Bug 4662 adding --with-libressl build option

2017-01-31 Thread Amos Jeffries
On 31/01/2017 7:04 a.m., Alex Rousskov wrote: > On 01/29/2017 04:26 AM, Amos Jeffries wrote: >> This is I think all we need to do code-wise to resolve the Bug 4662 >> issues with LibreSSL being incompatible with OpenSSL 1.1. >> >> The libraries cannot both be linked either way. If both --with-*

Re: [squid-dev] [PATCH] Bug 4662 adding --with-libressl build option

2017-01-30 Thread Alex Rousskov
On 01/29/2017 04:26 AM, Amos Jeffries wrote: > This is I think all we need to do code-wise to resolve the Bug 4662 > issues with LibreSSL being incompatible with OpenSSL 1.1. > > The libraries cannot both be linked either way. If both --with-* options > are provided LibreSSL currently overrides