Re: [squid-dev] [PATCH] PackableStream for cachemgr reports

2015-08-10 Thread Alex Rousskov
On 08/09/2015 01:47 AM, Amos Jeffries wrote: However the char(int_type) type constructor is necessary because this is the fundamental int_type being passed in. All the available *_castchar() operators are built to convert a 32-bit int_type value into an array of 4 bytes before dealing with the

Re: [squid-dev] [PATCH] PackableStream for cachemgr reports

2015-08-10 Thread Alex Rousskov
On 08/09/2015 09:39 PM, Amos Jeffries wrote: Primarily that we can do the formatting cleanup without adding a circular dependency between libbase and libmem in the current code situation. This answer to my Why do the same change twice? question does not compute/correlate for me. I do not

Re: [squid-dev] [PATCH] PackableStream for cachemgr reports

2015-08-09 Thread Alex Rousskov
On 08/09/2015 01:47 AM, Amos Jeffries wrote: On 9/08/2015 1:14 p.m., Alex Rousskov wrote: On 08/08/2015 02:03 AM, Amos Jeffries wrote: * convert old Action classes to new API * refactor old C-code report generators to be Action classes - fixing display output syntax to minimal YAML as we go

Re: [squid-dev] [PATCH] PackableStream for cachemgr reports

2015-08-09 Thread Amos Jeffries
On 10/08/2015 9:59 a.m., Alex Rousskov wrote: On 08/09/2015 01:47 AM, Amos Jeffries wrote: On 9/08/2015 1:14 p.m., Alex Rousskov wrote: On 08/08/2015 02:03 AM, Amos Jeffries wrote: * convert old Action classes to new API * refactor old C-code report generators to be Action classes - fixing

Re: [squid-dev] [PATCH] PackableStream for cachemgr reports

2015-08-09 Thread Amos Jeffries
[ I've re-ordered the discussion points so the important design part we ended discussion with is now at the top for first consideration. Depending on that the rest of it may or may not matter. ] On 9/08/2015 1:14 p.m., Alex Rousskov wrote: On 08/08/2015 02:03 AM, Amos Jeffries wrote: *

Re: [squid-dev] [PATCH] PackableStream for cachemgr reports

2015-08-08 Thread Alex Rousskov
On 08/08/2015 02:03 AM, Amos Jeffries wrote: On 8/08/2015 5:04 p.m., Alex Rousskov wrote: On 08/05/2015 10:24 AM, Amos Jeffries wrote: +virtual int_type overflow(int_type aChar = traits_type::eof()) { +virtual int sync() { +virtual std::streamsize xsputn(const char * chars,

Re: [squid-dev] [PATCH] PackableStream for cachemgr reports

2015-08-06 Thread Kinkie
I like this. On Wed, Aug 5, 2015 at 6:24 PM, Amos Jeffries squ...@treenet.co.nz wrote: Adds a PackableStream class which provides std::ostream semantics for writing data to a cachemgr report. FYI: This follows on from discussiosn back in 2011 regarding how to restructure the cachemgr

[squid-dev] [PATCH] PackableStream for cachemgr reports

2015-08-05 Thread Amos Jeffries
Adds a PackableStream class which provides std::ostream semantics for writing data to a cachemgr report. FYI: This follows on from discussiosn back in 2011 regarding how to restructure the cachemgr internal data storage for relay between workers vs the report output formatting. Current trunk