On Thu, Oct 27, 2016 at 5:10 AM, Alex Rousskov
wrote:
> On 10/26/2016 05:18 PM, Kinkie wrote:
the attached patch refactors the use of wordlist to SBufList in
acl/RegexData.cc
>
>> -while (wl != NULL) {
>> +for (SBuf i : sl) {
>
> If possible,
On 10/26/2016 05:18 PM, Kinkie wrote:
>>> the attached patch refactors the use of wordlist to SBufList in
>>> acl/RegexData.cc
> -while (wl != NULL) {
> +for (SBuf i : sl) {
If possible, please avoid creating new SBufs by declaring "i" to be a
constant reference to SBuf. It is probably
On Wed, Oct 26, 2016 at 10:40 PM, Amos Jeffries wrote:
> On 27/10/2016 9:16 a.m., Kinkie wrote:
>> Hi all,
>>the attached patch refactors the use of wordlist to SBufList in
>> acl/RegexData.cc; the "test.txt" attachment shows the output of
>> "./src/squid -X 2>&1 | grep
On 27/10/2016 9:16 a.m., Kinkie wrote:
> Hi all,
>the attached patch refactors the use of wordlist to SBufList in
> acl/RegexData.cc; the "test.txt" attachment shows the output of
> "./src/squid -X 2>&1 | grep 'RegexData' >/tmp/test_plan.txt" when
> applied to a default configuration file with
Hi all,
the attached patch refactors the use of wordlist to SBufList in
acl/RegexData.cc; the "test.txt" attachment shows the output of
"./src/squid -X 2>&1 | grep 'RegexData' >/tmp/test_plan.txt" when
applied to a default configuration file with these additions:
acl t1 dstdom_regex pattern1