Re: [squid-dev] [PATCH] auth_schemes directive

2016-12-10 Thread Amos Jeffries
On 10/12/2016 6:06 p.m., Alex Rousskov wrote: > On 12/08/2016 09:38 PM, Amos Jeffries wrote: >>> Custom actions patch applied as squid-5-14971. > >> PS, also applied for 4.0.17 > > > Which v4 revision? I do not see it after bzr update of that branch and > and it does not seem to be present at >

Re: [squid-dev] [PATCH] auth_schemes directive

2016-12-09 Thread Alex Rousskov
On 12/08/2016 09:38 PM, Amos Jeffries wrote: >> Custom actions patch applied as squid-5-14971. > PS, also applied for 4.0.17 Which v4 revision? I do not see it after bzr update of that branch and and it does not seem to be present at https://code.launchpad.net/~squid/squid/4 Thank you, Alex.

Re: [squid-dev] [PATCH] auth_schemes directive

2016-12-09 Thread Alex Rousskov
On 12/08/2016 09:37 PM, Amos Jeffries wrote: > On 9/12/2016 5:03 p.m., Alex Rousskov wrote: >> On 12/08/2016 06:39 PM, Amos Jeffries wrote: >>> On 6/12/2016 10:57 a.m., Eduard Bagdasaryan wrote: Attached two patches for v5 after splitting. >>> Thank you. Custom actions patch applied as

Re: [squid-dev] [PATCH] auth_schemes directive

2016-12-08 Thread Amos Jeffries
On 9/12/2016 2:39 p.m., Amos Jeffries wrote: > On 6/12/2016 10:57 a.m., Eduard Bagdasaryan wrote: >> >> Attached two patches for v5 after splitting. Please apply >> SQUID-242-refactor-custom-acl-actions-cfg-t1.patch first. >> > > Thank you. Custom actions patch applied as squid-5-14971. > PS,

Re: [squid-dev] [PATCH] auth_schemes directive

2016-12-08 Thread Amos Jeffries
On 9/12/2016 5:03 p.m., Alex Rousskov wrote: > On 12/08/2016 06:39 PM, Amos Jeffries wrote: >> On 6/12/2016 10:57 a.m., Eduard Bagdasaryan wrote: >>> >>> Attached two patches for v5 after splitting. Please apply >>> SQUID-242-refactor-custom-acl-actions-cfg-t1.patch first. >>> >> >> Thank you.

Re: [squid-dev] [PATCH] auth_schemes directive

2016-12-08 Thread Alex Rousskov
On 12/08/2016 06:39 PM, Amos Jeffries wrote: > On 6/12/2016 10:57 a.m., Eduard Bagdasaryan wrote: >> >> Attached two patches for v5 after splitting. Please apply >> SQUID-242-refactor-custom-acl-actions-cfg-t1.patch first. >> > > Thank you. Custom actions patch applied as squid-5-14971. If there

Re: [squid-dev] [PATCH] auth_schemes directive

2016-12-08 Thread Amos Jeffries
On 6/12/2016 10:57 a.m., Eduard Bagdasaryan wrote: > > Attached two patches for v5 after splitting. Please apply > SQUID-242-refactor-custom-acl-actions-cfg-t1.patch first. > Thank you. Custom actions patch applied as squid-5-14971. Amos ___

Re: [squid-dev] [PATCH] auth_schemes directive

2016-12-05 Thread Eduard Bagdasaryan
Attached two patches for v5 after splitting. Please apply SQUID-242-refactor-custom-acl-actions-cfg-t1.patch first. Regards, Eduard On 02.12.2016 19:41, Alex Rousskov wrote: Directive naming aside, since what you have proposed is already implemented, we will proceed with splitting the patch

Re: [squid-dev] [PATCH] auth_schemes directive

2016-12-02 Thread Alex Rousskov
On 12/01/2016 11:53 PM, Amos Jeffries wrote: > Not sure if you intended to but you have just done a good CHI test. I do not know what you mean by "CHI test". Googling did not help. > Your wording/layout of that directive has clearly collided with some > other config grammar that user is more

Re: [squid-dev] [PATCH] auth_schemes directive

2016-12-01 Thread Amos Jeffries
On 1/12/2016 8:00 a.m., Alex Rousskov wrote: > On 11/30/2016 12:06 AM, Alex Rousskov wrote: >> Perhaps there is a way to keep the per-scheme access list advantage >> without opening the 403 Pandora box and preserving the whole-list >> visualization provided by auth_schemes? >> >> For example, we

Re: [squid-dev] [PATCH] auth_schemes directive

2016-11-30 Thread Alex Rousskov
On 11/30/2016 12:06 AM, Alex Rousskov wrote: > Perhaps there is a way to keep the per-scheme access list advantage > without opening the 403 Pandora box and preserving the whole-list > visualization provided by auth_schemes? > > For example, we could support something like this: > >

Re: [squid-dev] [PATCH] auth_schemes directive

2016-11-29 Thread Amos Jeffries
On 30/11/2016 2:11 p.m., Alex Rousskov wrote: > On 11/29/2016 03:50 PM, Amos Jeffries wrote: >> On 28/11/2016 3:34 p.m., Alex Rousskov wrote: >>> Or being able to control the order of schemes presented to the user. > >> Any HTTP client implementation which was coded to be properly compliant >>

Re: [squid-dev] [PATCH] auth_schemes directive

2016-11-29 Thread Alex Rousskov
On 11/29/2016 03:50 PM, Amos Jeffries wrote: > On 28/11/2016 3:34 p.m., Alex Rousskov wrote: >> Or being able to control the order of schemes presented to the user. > Any HTTP client implementation which was coded to be properly compliant > with RFC 2616 and 2617 *will not* obey any ordering

Re: [squid-dev] [PATCH] auth_schemes directive

2016-11-29 Thread Amos Jeffries
On 28/11/2016 3:34 p.m., Alex Rousskov wrote: > On 11/19/2016 02:15 AM, Amos Jeffries wrote: >> On 19/11/2016 12:56 p.m., Eduard Bagdasaryan wrote: >>> This patch introduces a new 'auth_schemes' squid.conf directive. >>> >>> This directive may be used to customize authentication >>> schemes

Re: [squid-dev] [PATCH] auth_schemes directive

2016-11-27 Thread Alex Rousskov
On 11/19/2016 02:15 AM, Amos Jeffries wrote: > On 19/11/2016 12:56 p.m., Eduard Bagdasaryan wrote: >> This patch introduces a new 'auth_schemes' squid.conf directive. >> >> This directive may be used to customize authentication >> schemes presence and order in Squid's HTTP 401 (Unauthorized) and

Re: [squid-dev] [PATCH] auth_schemes directive

2016-11-22 Thread Eduard Bagdasaryan
2016-11-19 12:15 GMT+03:00 Amos Jeffries : > To add auth scheme access controls in a way that does not actively > prevent (1) from being implemented later IMO we need to add access > controls as a member of the Config object, *not* as a global access list. > > The config

Re: [squid-dev] [PATCH] auth_schemes directive

2016-11-19 Thread Amos Jeffries
On 19/11/2016 12:56 p.m., Eduard Bagdasaryan wrote: > Hello, > > This patch introduces a new 'auth_schemes' squid.conf directive. > > This directive may be used to customize authentication > schemes presence and order in Squid's HTTP 401 (Unauthorized) and 407 > (Proxy Authentication Required)

[squid-dev] [PATCH] auth_schemes directive

2016-11-18 Thread Eduard Bagdasaryan
Hello, This patch introduces a new 'auth_schemes' squid.conf directive. This directive may be used to customize authentication schemes presence and order in Squid's HTTP 401 (Unauthorized) and 407 (Proxy Authentication Required) responses. The defaults remain the same. Also refactored