Re: [squid-dev] [PATCH] coverity-fixes, part 2: SBuf hasher

2015-08-27 Thread Kinkie
Hi, the attached patch implements this suggestion renaming to SBufHashCommon_ (it seems to be a common pattern) and adding a comment. On Mon, Aug 24, 2015 at 8:51 PM, Alex Rousskov rouss...@measurement-factory.com wrote: On 08/24/2015 11:13 AM, Kinkie wrote: this is part 2 of the

Re: [squid-dev] [PATCH] coverity-fixes, part 2: SBuf hasher

2015-08-27 Thread Alex Rousskov
On 08/27/2015 09:51 AM, Kinkie wrote: Hi, the attached patch implements this suggestion renaming to SBufHashCommon_ (it seems to be a common pattern) and adding a comment. Thank you for changing this. This editorial change did not require a new review round IMHO. Alex. On Mon, Aug 24,

[squid-dev] [PATCH] coverity-fixes, part 2: SBuf hasher

2015-08-24 Thread Kinkie
Hi, this is part 2 of the coverity-fixes merge: SBuf hash. This code allows to have std::unordered_maps where the key is a SBuf, in case-sensitive and case-insensitive variants. The hashing is the same as used in the current Squid hash implementation (from lib/hash.cc) in order not to upset the

Re: [squid-dev] [PATCH] coverity-fixes, part 2: SBuf hasher

2015-08-24 Thread Alex Rousskov
On 08/24/2015 11:13 AM, Kinkie wrote: this is part 2 of the coverity-fixes merge: SBuf hash. This code allows to have std::unordered_maps where the key is a SBuf, in case-sensitive and case-insensitive variants. The hashing is the same as used in the current Squid hash implementation (from