Re: [squid-dev] [PATCH] remove ip/Qos.cci

2017-01-07 Thread Amos Jeffries
On 2017-01-08 06:33, Kinkie wrote: Looks good, except that +Qos::Config() {STUB} Surrounding the STUB macro in brackets is not the common style (although it is harmless and could actually be a good idea) +1, possibly with this change There was some reason for that which I've forgotten the

Re: [squid-dev] [PATCH] remove ip/Qos.cci

2017-01-07 Thread Alex Rousskov
On 01/07/2017 04:46 AM, Amos Jeffries wrote: > This patch removes ip/Qos.cci file moving its content to ip/QosConfig.cc. > > Also, move the stub file to src/tests/stub_libip.cc and update to use > tests/STUB.h interface. > +bool > +Ip::Qos::Config::isHitTosActive() const > +{ > +return

Re: [squid-dev] [PATCH] remove ip/Qos.cci

2017-01-07 Thread Kinkie
Looks good, except that +Qos::Config() {STUB} Surrounding the STUB macro in brackets is not the common style (although it is harmless and could actually be a good idea) +1, possibly with this change On Sat, Jan 7, 2017 at 11:46 AM, Amos Jeffries wrote: > This patch

[squid-dev] [PATCH] remove ip/Qos.cci

2017-01-07 Thread Amos Jeffries
This patch removes ip/Qos.cci file moving its content to ip/QosConfig.cc. Also, move the stub file to src/tests/stub_libip.cc and update to use tests/STUB.h interface. Amos === modified file 'src/ip/Makefile.am' --- src/ip/Makefile.am 2017-01-01 00:12:22 + +++ src/ip/Makefile.am