Re: [squid-dev] [PATCH] squid-3.5: fix for errors when receiving a non-existent file via ftp

2015-10-13 Thread Amos Jeffries
Applied to Squid-4 as rev.14355 Amos ___ squid-dev mailing list squid-dev@lists.squid-cache.org http://lists.squid-cache.org/listinfo/squid-dev

Re: [squid-dev] [PATCH] squid-3.5: fix for errors when receiving a non-existent file via ftp

2015-10-12 Thread Vitaly Lavrov
On 12.10.2015 18:40, Amos Jeffries wrote: On 12/10/2015 9:21 p.m., Vitaly Lavrov wrote: On 11.10.2015 18:56, Amos Jeffries wrote: Attached is a cleaned version of the patch. It now meets the source coding guidelines, and applies cleanly to trunk / Squid-4. I took the opportunity to remove two

Re: [squid-dev] [PATCH] squid-3.5: fix for errors when receiving a non-existent file via ftp

2015-10-12 Thread Amos Jeffries
On 12/10/2015 9:21 p.m., Vitaly Lavrov wrote: > On 11.10.2015 18:56, Amos Jeffries wrote: >> Attached is a cleaned version of the patch. It now meets the source >> coding guidelines, and applies cleanly to trunk / Squid-4. >> >> I took the opportunity to remove two useless if() conditions - one was

Re: [squid-dev] [PATCH] squid-3.5: fix for errors when receiving a non-existent file via ftp

2015-10-12 Thread Vitaly Lavrov
On 11.10.2015 18:56, Amos Jeffries wrote: Attached is a cleaned version of the patch. It now meets the source coding guidelines, and applies cleanly to trunk / Squid-4. I took the opportunity to remove two useless if() conditions - one was duplicate checking a value, the other for values in a po

Re: [squid-dev] [PATCH] squid-3.5: fix for errors when receiving a non-existent file via ftp

2015-10-11 Thread Amos Jeffries
Attached is a cleaned version of the patch. It now meets the source coding guidelines, and applies cleanly to trunk / Squid-4. I took the opportunity to remove two useless if() conditions - one was duplicate checking a value, the other for values in a pointer that was just new()'d. Logic looks m

Re: [squid-dev] [PATCH] squid-3.5: fix for errors when receiving a non-existent file via ftp

2015-10-09 Thread Vitaly Lavrov
On 09.10.2015 04:45, Amos Jeffries wrote: On 9/10/2015 3:15 a.m., Vitaly Lavrov wrote: On 07.10.2015 22:47, Alex Rousskov wrote: Hello Alex. Thanks for the quick response. Hello Vitaly, I am glad you were able to fix the problem, and I thank you for sharing your fix. Unfortunately, th

Re: [squid-dev] [PATCH] squid-3.5: fix for errors when receiving a non-existent file via ftp

2015-10-08 Thread Amos Jeffries
On 9/10/2015 3:15 a.m., Vitaly Lavrov wrote: > On 07.10.2015 22:47, Alex Rousskov wrote: > > Hello Alex. > > Thanks for the quick response. >> Hello Vitaly, >> >> I am glad you were able to fix the problem, and I thank you for >> sharing your fix. >> >> Unfortunately, the patch itself needs

[squid-dev] [PATCH] squid-3.5: fix for errors when receiving a non-existent file via ftp

2015-10-08 Thread Vitaly Lavrov
On 07.10.2015 22:47, Alex Rousskov wrote: Hello Alex. Thanks for the quick response. Hello Vitaly, I am glad you were able to fix the problem, and I thank you for sharing your fix. Unfortunately, the patch itself needs significant refactoring because you are [incorrectly] duplicating an

Re: [squid-dev] [PATCH] squid-3.5: fix for errors when receiving a non-existent file via ftp

2015-10-07 Thread Alex Rousskov
On 10/07/2015 12:16 PM, Vitaly Lavrov wrote: > Bug 4279: No response from proxy for FTP-download of non-existing file > > There is no code to handle errors ftp-protocol functions ftpFail(). > The patch forms a response to the client an error similar to loginFailed(). > To handle specific errors, y

[squid-dev] [PATCH] squid-3.5: fix for errors when receiving a non-existent file via ftp

2015-10-07 Thread Vitaly Lavrov
Bug 4279: No response from proxy for FTP-download of non-existing file There is no code to handle errors ftp-protocol functions ftpFail(). The patch forms a response to the client an error similar to loginFailed(). To handle specific errors, you must add code in failedHttpStatus(). If you add to