Re: [squid-dev] [PATCH] ssl::server_name ACL badly broken since inception (trunk r14008).

2016-11-14 Thread Amos Jeffries
On 28/10/2016 9:39 p.m., Christos Tsantilas wrote: > Patch applied to trunk as r14898. > > I am attaching the squid-3.5 version of the patch. > Applied to 3.5 as r14110. Amos ___ squid-dev mailing list squid-dev@lists.squid-cache.org

Re: [squid-dev] [PATCH] ssl::server_name ACL badly broken since inception (trunk r14008).

2016-11-09 Thread Amos Jeffries
On 10/11/2016 4:24 a.m., Alex Rousskov wrote: > On 10/28/2016 02:39 AM, Christos Tsantilas wrote: > >> I am attaching the squid-3.5 version of the patch. > > Amos, will you commit this fix to the v3.5 branch? > Sure. Will do in the next few days sometime. Amos

Re: [squid-dev] [PATCH] ssl::server_name ACL badly broken since inception (trunk r14008).

2016-11-09 Thread Alex Rousskov
On 10/28/2016 02:39 AM, Christos Tsantilas wrote: > I am attaching the squid-3.5 version of the patch. Amos, will you commit this fix to the v3.5 branch? Thank you, Alex. > On 10/27/2016 12:46 AM, Amos Jeffries wrote: >> On 21/10/2016 5:18 a.m., Christos Tsantilas wrote: >>> >>> The

Re: [squid-dev] [PATCH] ssl::server_name ACL badly broken since inception (trunk r14008).

2016-10-28 Thread Christos Tsantilas
Patch applied to trunk as r14898. I am attaching the squid-3.5 version of the patch. On 10/27/2016 12:46 AM, Amos Jeffries wrote: On 21/10/2016 5:18 a.m., Christos Tsantilas wrote: The original server_name code mishandled all SNI checks and some rare host checks: * The SNI-derived value

Re: [squid-dev] [PATCH] ssl::server_name ACL badly broken since inception (trunk r14008).

2016-10-26 Thread Amos Jeffries
On 21/10/2016 5:18 a.m., Christos Tsantilas wrote: > > The original server_name code mishandled all SNI checks and some rare > host checks: > > * The SNI-derived value was pointing to an already freed memory storage. > * Missing host-derived values were not detected (host() is never nil). > *

[squid-dev] [PATCH] ssl::server_name ACL badly broken since inception (trunk r14008).

2016-10-20 Thread Christos Tsantilas
The original server_name code mishandled all SNI checks and some rare host checks: * The SNI-derived value was pointing to an already freed memory storage. * Missing host-derived values were not detected (host() is never nil). * Mismatches were re-checked with an undocumented "none" value