On 4/4/20 2:49 AM, Francesco Chemolli wrote:
> I’m mostly done in a PR replacing the dlink with a std::list but without
> changing the overall design. It does kill a few tens of lines of code
> and is clearer to read tho.
Please note that std::list is usually a lot more expensive than dlink
(i.e.
It was quite fast really as my PR doesn’t address the fundamental design
issues nor much of the coding style. A quick win could be to move from a
list to an unordered_map, it’s a quite trivial cache in the end. There’s a
lot of machinery in there for such a simple data structure :/
On Sat, 4 Apr 2
On 4/04/20 7:49 pm, Francesco Chemolli wrote:
> I am not sure about what you recommend to do here.
> This cache is IMO over complicated and it breaks layering.
> I’m mostly done in a PR replacing the dlink with a std::list but without
> changing the overall design. It does kill a few tens of lines
I am not sure about what you recommend to do here.
This cache is IMO over complicated and it breaks layering.
I’m mostly done in a PR replacing the dlink with a std::list but without
changing the overall design. It does kill a few tens of lines of code and
is clearer to read tho.
On Sat, 4 Apr 202
On 4/04/20 3:34 am, Alex Rousskov wrote:
> On 4/3/20 7:25 AM, Francesco Chemolli wrote:
>
>> I'm looking at places where to improve things a bit, and I stumbled
>> across cacheMatchAcl . It tries hard to be generic, but it is only ever
>> used in ACLProxyAuth::matchProxyAuth . Would it make sens
On 4/3/20 7:25 AM, Francesco Chemolli wrote:
> I'm looking at places where to improve things a bit, and I stumbled
> across cacheMatchAcl . It tries hard to be generic, but it is only ever
> used in ACLProxyAuth::matchProxyAuth . Would it make sense to just have
> a specialised cache for proxyau
Hi all,
I'm looking at places where to improve things a bit, and I stumbled
across cacheMatchAcl . It tries hard to be generic, but it is only ever
used in ACLProxyAuth::matchProxyAuth . Would it make sense to just have a
specialised cache for proxyauth?
--
Francesco
___
