On 10/29/20 7:41 AM, Amos Jeffries wrote:
> The latest Squid have AnyP::Uri::Encode() whic uses a caller provided
> buffer.
Just to avoid misunderstanding: AnyP::Uri::Encode() uses a
caller-provided buffer as _input_. So does rfc1738*_escape(), of course.
That kind of input is unavoidable and is
On 10/29/20 7:17 AM, Damian Wojslaw wrote:
> It was mentioned that rfc1738_do_escape could use changing so it doesn't
> return static buffer.
Yes. Most likely, rfc1738 family of functions should return an SBuf, but
refactoring that may require a serious effort, on several layers. This
is not the
On Thu, Oct 29, 2020 at 12:49 PM Amos Jeffries wrote:
>
> The latest Squid have AnyP::Uri::Encode() whic uses a caller provided
> buffer. What needs doing now is finding old rfc1738*_escape() which can
> be replaced with the new API.
>
> For example; code like urlCanonicalCleanWithoutRequest() wh
On 30/10/20 12:17 am, Damian Wojslaw wrote:
Helo
I've been recently following the PR that addresses issue with
authentication in cachemgr.cc.
It was mentioned that rfc1738_do_escape could use changing so it doesn't
return static buffer.
The latest Squid have AnyP::Uri::Encode() whic uses a c
Helo
I've been recently following the PR that addresses issue with
authentication in cachemgr.cc.
It was mentioned that rfc1738_do_escape could use changing so it doesn't
return static buffer.
I'm interested in working on it. I'm also interested in getting my hands in
cachegr.cc, as it was describ
