Re: [squid-dev] RFC: policy change for header #includes

2023-03-08 Thread Alex Rousskov
On 3/8/23 09:12, Amos Jeffries wrote: On 7/03/2023 10:14 pm, Francesco Chemolli wrote: I would also complement it with the directive to use header instead of whenever possible That we already have. PRs doing the updates welcome. Agreed on both counts, especially if an updating PR

Re: [squid-dev] RFC: policy change for header #includes

2023-03-08 Thread Amos Jeffries
On 7/03/2023 10:14 pm, Francesco Chemolli wrote: I like this idea; I would also complement it with the directive to use header instead of whenever possible - this could also be automatically enforced That we already have. PRs doing the updates welcome. Amos

Re: [squid-dev] RFC: policy change for header #includes

2023-03-07 Thread Alex Rousskov
On 3/7/23 00:38, Amos Jeffries wrote: Current Policy https://wiki.squid-cache.org/DeveloperResources/SquidCodingGuidelines#file-include-guidelines:  4. system C headers (with a .h suffix):     * mandatory HAVE_FOO_H wrapper I propose using the C++17 "__has_include()" instead of

Re: [squid-dev] RFC: policy change for header #includes

2023-03-07 Thread Francesco Chemolli
I like this idea; I would also complement it with the directive to use header instead of whenever possible - this could also be automatically enforced On Tue, Mar 7, 2023 at 5:38 AM Amos Jeffries wrote: > > Current Policy > < >