Re: [squid-dev] [PATCH] Deprecating SMB LanMan helpers

[Kinkie]

+1.

On Thu, May 26, 2016 at 10:03 AM, Amos Jeffries  wrote:
> Bring the SMB LanMan helpers one step closer to removal by dropping them
> from the set of helpers which are auto-detected and built by default
> with Squid.
>
> They are still available for the minority using them. But need to be
> explicitly listed in the ./configure options to be built.
>
> Amos
>
> ___
> squid-dev mailing list
> squid-dev@lists.squid-cache.org
> http://lists.squid-cache.org/listinfo/squid-dev
>



-- 
Francesco
___
squid-dev mailing list
squid-dev@lists.squid-cache.org
http://lists.squid-cache.org/listinfo/squid-dev

Re: [squid-dev] [PATCH] Drop ie_refresh configuration option

[Kinkie]

+1.

On Thu, May 26, 2016 at 10:16 AM, Amos Jeffries  wrote:
> This option was provided as a hack to workaround problems in MSIE 5.01
> and older.
>
> Since those MSIE versions are long deprecated and no longer even
> registering on the popularity charts for more than 5 years I think its
> time we removed this hack.
>
> Amos
>
> ___
> squid-dev mailing list
> squid-dev@lists.squid-cache.org
> http://lists.squid-cache.org/listinfo/squid-dev
>



-- 
Francesco
___
squid-dev mailing list
squid-dev@lists.squid-cache.org
http://lists.squid-cache.org/listinfo/squid-dev

[squid-dev] [PATCH] Drop ie_refresh configuration option

[Amos Jeffries]

This option was provided as a hack to workaround problems in MSIE 5.01
and older.

Since those MSIE versions are long deprecated and no longer even
registering on the popularity charts for more than 5 years I think its
time we removed this hack.

Amos
=== modified file 'doc/release-notes/release-4.sgml'
--- doc/release-notes/release-4.sgml2016-05-06 10:06:01 +
+++ doc/release-notes/release-4.sgml2016-05-26 09:14:20 +
@@ -343,6 +343,9 @@
Superceded by cache_peer_access. Use dstdomain ACL
   in the access control list to restrict domains requested.
 
+   ie_refresh
+   Removed. MSIE 3.x, 4.x, 5.0 and 5.01 are no longer popular browsers.
+
sslproxy_cafile
Replaced by tls_outgoing_options cafile=.
   Which now takes multiple entries.
=== modified file 'src/cf.data.pre'
--- src/cf.data.pre 2016-05-05 06:31:11 +
+++ src/cf.data.pre 2016-05-26 09:06:49 +
@@ -163,13 +163,19 @@
This option is not yet supported by Squid-3.
 DOC_END
 
-# Options removed in 3.6
+# Options removed in 4.x
 NAME: cache_peer_domain cache_host_domain
 TYPE: obsolete
 DOC_START
Replace with dstdomain ACLs and cache_peer_access.
 DOC_END
 
+NAME: ie_refresh
+TYPE: obsolete
+DOC_START
+   This option is no longer supported.
+DOC_END
+
 NAME: sslproxy_cafile
 TYPE: obsolete
 DOC_START
@@ -5889,30 +5895,6 @@
replies as required by RFC2616.
 DOC_END
 
-NAME: ie_refresh
-COMMENT: on|off
-TYPE: onoff
-LOC: Config.onoff.ie_refresh
-DEFAULT: off
-DOC_START
-   Microsoft Internet Explorer up until version 5.5 Service
-   Pack 1 has an issue with transparent proxies, wherein it
-   is impossible to force a refresh.  Turning this on provides
-   a partial fix to the problem, by causing all IMS-REFRESH
-   requests from older IE versions to check the origin server
-   for fresh content.  This reduces hit ratio by some amount
-   (~10% in my experience), but allows users to actually get
-   fresh content when they want it.  Note because Squid
-   cannot tell if the user is using 5.5 or 5.5SP1, the behavior
-   of 5.5 is unchanged from old versions of Squid (i.e. a
-   forced refresh is impossible).  Newer versions of IE will,
-   hopefully, continue to have the new behavior and will be
-   handled based on that assumption.  This option defaults to
-   the old Squid behavior, which is better for hit ratios but
-   worse for clients using IE, if they need to be able to
-   force fresh content.
-DOC_END
-
 NAME: vary_ignore_expire
 COMMENT: on|off
 TYPE: onoff

=== modified file 'src/client_side_request.cc'
--- src/client_side_request.cc  2016-05-03 01:48:49 +
+++ src/client_side_request.cc  2016-05-26 09:05:05 +
@@ -1072,28 +1072,6 @@
 // RFC 2616: treat Pragma:no-cache as if it was 
Cache-Control:no-cache when Cache-Control is missing
 } else if (req_hdr->has(Http::HdrType::PRAGMA))
 no_cache = 
req_hdr->hasListMember(Http::HdrType::PRAGMA,"no-cache",',');
-
-/*
-* Work around for supporting the Reload button in IE browsers when 
Squid
-* is used as an accelerator or transparent proxy, by turning 
accelerated
-* IMS request to no-cache requests. Now knows about IE 5.5 fix (is
-* actually only fixed in SP1, but we can't tell whether we are talking 
to
-* SP1 or not so all 5.5 versions are treated 'normally').
-*/
-if (Config.onoff.ie_refresh) {
-if (http->flags.accel && request->flags.ims) {
-if ((str = req_hdr->getStr(Http::HdrType::USER_AGENT))) {
-if (strstr(str, "MSIE 5.01") != NULL)
-no_cache=true;
-else if (strstr(str, "MSIE 5.0") != NULL)
-no_cache=true;
-else if (strstr(str, "MSIE 4.") != NULL)
-no_cache=true;
-else if (strstr(str, "MSIE 3.") != NULL)
-no_cache=true;
-}
-}
-}
 }
 
 if (request->method == Http::METHOD_OTHER) {

___
squid-dev mailing list
squid-dev@lists.squid-cache.org
http://lists.squid-cache.org/listinfo/squid-dev

[squid-dev] [PATCH] Deprecating SMB LanMan helpers

[Amos Jeffries]

Bring the SMB LanMan helpers one step closer to removal by dropping them
from the set of helpers which are auto-detected and built by default
with Squid.

They are still available for the minority using them. But need to be
explicitly listed in the ./configure options to be built.

Amos
=== modified file 'configure.ac'
--- configure.ac2016-05-21 12:12:51 +
+++ configure.ac2016-05-26 07:04:24 +
@@ -2483,6 +2483,7 @@
 SQUID_DEFINE_BOOL(USE_AUTH,$enable_auth,[Enable support for authentication])
 AM_CONDITIONAL(ENABLE_AUTH, test "x$enable_auth" != "xno")
 AUTH_MODULES=""
+require_smblib=0
 
 AC_ARG_ENABLE(auth-basic,
   AS_HELP_STRING([--enable-auth-basic="list of helpers"],
@@ -2542,6 +2543,7 @@
 done
 AC_SUBST(AUTH_MODULES)
 AC_SUBST(AUTH_LIBS_TO_BUILD)
+AM_CONDITIONAL(ENABLE_SMBLIB, $require_smblib)
 
 dnl Select logging daemon helpers to build
 AC_ARG_ENABLE(log-daemon-helpers,

=== modified file 'lib/Makefile.am'
--- lib/Makefile.am 2016-01-05 13:00:50 +
+++ lib/Makefile.am 2016-05-26 02:24:40 +
@@ -37,7 +37,10 @@
 noinst_LTLIBRARIES += libsspwin32.la
 libsspwin32_la_SOURCES = sspwin32.cc
 else
-SUBDIRS += rfcnb smblib
+SUBDIRS += rfcnb
+if ENABLE_SMBLIB
+SUBDIRS += smblib
+endif
 EXTRA_DIST += sspwin32.cc
 endif
 if ENABLE_AUTH_NTLM

=== modified file 'src/auth/basic/SMB_LM/required.m4'
--- src/auth/basic/SMB_LM/required.m4   2016-01-01 00:12:18 +
+++ src/auth/basic/SMB_LM/required.m4   2016-05-26 07:04:53 +
@@ -5,7 +5,10 @@
 ## Please see the COPYING and CONTRIBUTORS files for details.
 ##
 
-BUILD_HELPER="SMB_LM"
-
 # DONT build this helper on Windows
-AC_CHECK_HEADERS([w32api/windows.h windows.h],[BUILD_HELPER=""])
+# DONT build this helper by default
+if test "x$auto_auth_basic_modules" != "xyes";then
+  BUILD_HELPER="SMB_LM"
+  AC_CHECK_HEADERS([w32api/windows.h windows.h],[BUILD_HELPER=""])
+  require_smblib= test "x$BUILD_HELPER" = "xSMB_LM"
+fi

=== modified file 'src/auth/ntlm/SMB_LM/required.m4'
--- src/auth/ntlm/SMB_LM/required.m42016-01-29 18:16:17 +
+++ src/auth/ntlm/SMB_LM/required.m42016-05-26 07:04:59 +
@@ -7,9 +7,11 @@
 
 #
 # DONT build this helper on Windows
+# DONT build this helper by default
 #
 # XXX: do we really need the mingw check?
-if test "$squid_host_os" != "mingw"; then
+if test "$squid_host_os" != "mingw" -a "x$auto_auth_ntlm_modules" != "xyes"; 
then
   BUILD_HELPER="SMB_LM"
   AC_CHECK_HEADERS([w32api/windows.h windows.h],[BUILD_HELPER=""])
+  require_smblib= test "x$BUILD_HELPER" = "xSMB_LM"
 fi

=== modified file 'doc/release-notes/release-4.sgml'
--- doc/release-notes/release-4.sgml2016-05-06 10:06:01 +
+++ doc/release-notes/release-4.sgml2016-05-26 08:47:32 +
@@ -411,10 +411,14 @@
 
--enable-auth-basic
The MSNT-multi-domain helper has been removed.
+   The SMB LanMan helper SMB_LM is no longer built by default.
+  It needs to be explicitly listed to be built.
 
--enable-auth-ntlm
The SMB LanMan helper is now built using SMB_LM
   (was lower case smb_lm).
+   The SMB LanMan helper SMB_LM is no longer built by default.
+  It needs to be explicitly listed to be built.
 
--enable-diskio
Auto-detection of SMP related modules has been fixed to

___
squid-dev mailing list
squid-dev@lists.squid-cache.org
http://lists.squid-cache.org/listinfo/squid-dev