Re: [squid-dev] [PATCH] Older response must not update

2016-08-27 Thread Alex Rousskov
On 08/27/2016 08:23 AM, Amos Jeffries wrote: > On 26/08/2016 5:05 a.m., Alex Rousskov wrote: >> I recommend renaming and re-documenting that subclass: >> >> /// Things that may happen to a transaction while it is being >> /// processed according to its LOG_* category. Logged as _SUFFIX(es). >> ///

Re: [squid-dev] [PATCH] Revalidate without Last-Modified

2016-08-27 Thread Alex Rousskov
On 08/27/2016 08:33 AM, Amos Jeffries wrote: > If the response Squid would emit to the client proxy would contain a > synthesized Last-Modified header - then the same synthetic value should > be sent in HTCP. I agree with that decision logic. > I think Squid should be emitting a synthetic L-M

Re: [squid-dev] [PATCH] Revalidate without Last-Modified

2016-08-27 Thread Alex Rousskov
On 08/27/2016 05:22 AM, Eduard Bagdasaryan wrote: > 2016-08-25 18:52 GMT+03:00 Alex Rousskov > : > >> 3. Sending an HTCP message to another service. >> >> > -hdr.putTime(Http::HdrType::LAST_MODIFIED, e->lastmod); >> > +if (e &&

Re: [squid-dev] [PATCH] Revalidate without Last-Modified

2016-08-27 Thread Amos Jeffries
On 27/08/2016 11:22 p.m., Eduard Bagdasaryan wrote: > 2016-08-25 18:52 GMT+03:00 Alex Rousskov: > >> 3. Sending an HTCP message to another service. >> >> > -hdr.putTime(Http::HdrType::LAST_MODIFIED, e->lastmod); >> > +if (e && e->lastModified() > -1) >> > +

Re: [squid-dev] [PATCH] Older response must not update

2016-08-27 Thread Amos Jeffries
On 26/08/2016 5:05 a.m., Alex Rousskov wrote: > On 08/25/2016 08:18 AM, Eduard Bagdasaryan wrote: >> 2016-08-24 18:20 GMT+03:00 Amos Jeffries : >> >>> in src/LogTags.cc: >>> * instead of adding new enum entry please extend LogTags with a new bool >>> flag and the c_str() to

Re: [squid-dev] [PATCH] Incorrect processing of long URIs

2016-08-27 Thread Amos Jeffries
On 26/08/2016 5:43 a.m., Alex Rousskov wrote: > On 08/25/2016 10:26 AM, Amos Jeffries wrote: >> About >> the only further optimization we can do there is make the >> "CharacterSet::SP" that it outputs in the sensitive path be a local >> static *within* DelimiterCharacters() itself and return a

Re: [squid-dev] [PATCH] Revalidate without Last-Modified

2016-08-27 Thread Eduard Bagdasaryan
2016-08-25 18:52 GMT+03:00 Alex Rousskov : > 3. Sending an HTCP message to another service. > > > -hdr.putTime(Http::HdrType::LAST_MODIFIED, e->lastmod); > > +if (e && e->lastModified() > -1) > > +