I did this change a bit differently, making these static SBufs
ACLHasComponentData class const members so that I could
reuse them in two methods, instead of duplicating C strings.
Reattaching the patch.
Eduard.
On 15.05.2017 14:38, Amos Jeffries wrote:
On 15/05/17 20:47, Eduard Bagdasaryan
Ssl::Lock class resides in
src/security/cert_generators/file/certificate_db.h.
Eduard.
On 15.05.2017 15:04, Amos Jeffries wrote:
A new File class guarantees atomic PID file operations using locks. We
tried to generalize/reuse Ssl::Lock from the certificate generation
What Ssl::Lock class?
On 05/15/2017 08:31 AM, Eduard Bagdasaryan wrote:
> I followed your plan with few adjustments and reattached the patch.
LGTM. Will commit soon if there are not objections.
Alex.
> On 06.05.2017 00:33, Alex Rousskov wrote:
>> On 04/27/2017 02:39 PM, Eduard Bagdasaryan wrote:
>>> +// always
I followed your plan with few adjustments and reattached the patch.
Since the new CachePeer::reprobe is a kind of 'helper' flag with
default value, I think no other initialization/reporting/cloning steps
needed (as for similar CachePeer::tcp_up).
Eduard.
On 06.05.2017 00:33, Alex Rousskov
On 07/05/17 09:59, Eduard Bagdasaryan wrote:
This patch makes PID file check/creation atomic to avoid associated
race conditions.
I do not see any use of atomic's in this patch. Please use std::atomic
locks to ensure actually atomic operations on the file locks. Squid does
have some child
