Re: [squid-dev] [PATCH] Ignore impossible SSL bumping actions, as intended and documented / bug 4237 fix

2015-08-19 Thread Tsantilas Christos
Patch applied to trunk as rev.14227 I am also attaching the squid-3.5 version of the patch. The trunk patch does not apply cleanly. On 08/15/2015 03:21 AM, Amos Jeffries wrote: On 15/08/2015 2:41 a.m., Tsantilas Christos wrote: Hi all, The wiki pages are fixed. Is it OK to commit this

Re: [squid-dev] [PATCH] Ignore impossible SSL bumping actions, as intended and documented / bug 4237 fix

2015-08-14 Thread Amos Jeffries
On 15/08/2015 2:41 a.m., Tsantilas Christos wrote: Hi all, The wiki pages are fixed. Is it OK to commit this patch? +1 from me. Please remove the ACLChecklist: part from the new debugs in ACLChecklist::bannedAction() during commit. Amos ___

Re: [squid-dev] [PATCH] Ignore impossible SSL bumping actions, as intended and documented / bug 4237 fix

2015-08-12 Thread Alex Rousskov
On 08/11/2015 10:40 AM, Amos Jeffries wrote: On 11/08/2015 11:24 p.m., Tsantilas Christos wrote: The reconnect is not yet implemented. Gah. So for the last year-ish it has been published in wiki SslPeekAndSplice page as an available config option. But is actually nothing more than an

Re: [squid-dev] [PATCH] Ignore impossible SSL bumping actions, as intended and documented / bug 4237 fix

2015-08-11 Thread Tsantilas Christos
On 08/11/2015 07:30 AM, Amos Jeffries wrote: On 11/08/2015 3:54 a.m., Tsantilas Christos wrote: According to Squid wiki: Some actions are not possible during certain processing steps. During a given processing step, Squid ignores ssl_bump lines with impossible actions. The distributed

Re: [squid-dev] [PATCH] Ignore impossible SSL bumping actions, as intended and documented / bug 4237 fix

2015-08-11 Thread Amos Jeffries
On 11/08/2015 11:24 p.m., Tsantilas Christos wrote: On 08/11/2015 07:30 AM, Amos Jeffries wrote: On 11/08/2015 3:54 a.m., Tsantilas Christos wrote: According to Squid wiki: Some actions are not possible during certain processing steps. During a given processing step, Squid ignores ssl_bump

Re: [squid-dev] [PATCH] Ignore impossible SSL bumping actions, as intended and documented / bug 4237 fix

2015-08-11 Thread Alex Rousskov
On 08/11/2015 10:40 AM, Amos Jeffries wrote: On 11/08/2015 11:24 p.m., Tsantilas Christos wrote: On 08/11/2015 07:30 AM, Amos Jeffries wrote: What about the other documented actions: * reconnect at step 1 2 The reconnect is not yet implemented. Gah. So for the last year-ish it has been

Re: [squid-dev] [PATCH] Ignore impossible SSL bumping actions, as intended and documented / bug 4237 fix

2015-08-11 Thread Amos Jeffries
On 12/08/2015 5:28 a.m., Alex Rousskov wrote: On 08/11/2015 10:40 AM, Amos Jeffries wrote: On 11/08/2015 11:24 p.m., Tsantilas Christos wrote: On 08/11/2015 07:30 AM, Amos Jeffries wrote: What about the other documented actions: * reconnect at step 1 2 The reconnect is not yet

Re: [squid-dev] [PATCH] Ignore impossible SSL bumping actions, as intended and documented / bug 4237 fix

2015-08-10 Thread Amos Jeffries
On 11/08/2015 3:54 a.m., Tsantilas Christos wrote: According to Squid wiki: Some actions are not possible during certain processing steps. During a given processing step, Squid ignores ssl_bump lines with impossible actions. The distributed squid.conf.documented has similar text. Current

[squid-dev] [PATCH] Ignore impossible SSL bumping actions, as intended and documented / bug 4237 fix

2015-08-10 Thread Tsantilas Christos
According to Squid wiki: Some actions are not possible during certain processing steps. During a given processing step, Squid ignores ssl_bump lines with impossible actions. The distributed squid.conf.documented has similar text. Current Squid violates the above rule. Squid considers all