Re: [squid-dev] [PATCH] Refactor IcmpConfig

2015-05-15 Thread Amos Jeffries
On 8/05/2015 8:23 p.m., Amos Jeffries wrote: Pull the IcmpConfig object out of the global SquidConfig structure and updates it to processing its own parse logics. Bringing it inline with the per-component configuration design in SourceLayout and HotConf projects. This allows us to use SBuf

Re: [squid-dev] [PATCH] Refactor IcmpConfig

2015-05-08 Thread Kinkie
Looks good to me. On Fri, May 8, 2015 at 10:23 AM, Amos Jeffries squ...@treenet.co.nz wrote: Pull the IcmpConfig object out of the global SquidConfig structure and updates it to processing its own parse logics. Bringing it inline with the per-component configuration design in SourceLayout and

[squid-dev] [PATCH] Refactor IcmpConfig

2015-05-08 Thread Amos Jeffries
Pull the IcmpConfig object out of the global SquidConfig structure and updates it to processing its own parse logics. Bringing it inline with the per-component configuration design in SourceLayout and HotConf projects. This allows us to use SBuf for storing the pinger program details and avoid