Re: [squid-dev] [PATCH] SBuf header names

2017-05-23 Thread Amos Jeffries 


On 29/04/17 07:31, Kinkie wrote:
Please correct the comment referencing this information, and this 
change is good to go :)


On Fri, 28 Apr 2017 at 21:14, Amos Jeffries > wrote:


On 29/04/17 04:52, Kinkie wrote:
> What's with the comment
>
> // TODO: this is probably incorrect, for now it should match w_space
>
> ?
> Apart from this, +1 from me.

I suspect that we need to change that whitespace check to conform
to the
updated WSP character set in RFC 7230/7231. For now I left it as the
characters in w_space which the removed call to strpbrk was using.

Amos



Applied to v5 as r15147.

Amos

___
squid-dev mailing list
squid-dev@lists.squid-cache.org
http://lists.squid-cache.org/listinfo/squid-dev

Re: [squid-dev] [PATCH] SBuf header names

2017-04-28 Thread Kinkie 
What's with the comment

// TODO: this is probably incorrect, for now it should match w_space

?
Apart from this, +1 from me.

On Sun, Apr 23, 2017 at 9:56 PM, Amos Jeffries  wrote:
> This patch replaces String with SBuf for storage of header names in
> HttpHeaderEntry.
>
> In the process we gain SBuf methods for delByName and hasNamed. Deprecating
> the char*  versions.
>
>
>
>
> Amos
>
>
> ___
> squid-dev mailing list
> squid-dev@lists.squid-cache.org
> http://lists.squid-cache.org/listinfo/squid-dev
>



-- 
Francesco
___
squid-dev mailing list
squid-dev@lists.squid-cache.org
http://lists.squid-cache.org/listinfo/squid-dev