Re: [MERGE] Rework urlAbsolute to be a little more streamlined.

2008-09-01 Thread Alex Rousskov
On Mon, 2008-09-01 at 12:42 +1000, Benno Rice wrote: Resubmit this patch, including changes based on comments by various people. - Mention RFC text in relation to changing the default behaviour in relation to unknown HTTP methods. - Use safe_free instead of xfree. - Rework urlAbsolute to

Re: pseudo-specs for a String class

2008-09-01 Thread Alex Rousskov
On Sun, 2008-08-31 at 14:07 +0200, Kinkie wrote: I've gotten a bit forward, now I'm a bit at a loss about where to go next. I would move string, stream, and other formatting functions away from this class. I would move searching and comparison functions away from this class. I would probably

Re: pseudo-specs for a String class

2008-09-01 Thread Alex Rousskov
On Sun, 2008-08-31 at 22:40 +0200, Kinkie wrote: On Sun, Aug 31, 2008 at 6:00 PM, Adrian Chadd [EMAIL PROTECTED] wrote: Do you really want to provide a 'consume' interface for a low-level representation of memory? I think trying to replace MemBuf with this new buffer is a bit silly.

Re: [MERGE] Rework urlAbsolute to be a little more streamlined.

2008-09-01 Thread Adrian Chadd
one zeroes, one doesn't. calloc is meant to be x objects of size y, but its effectively also a bzero(). Adrian 2008/9/2 Amos Jeffries [EMAIL PROTECTED]: On 01/09/2008, at 1:01 PM, Amos Jeffries wrote: Resubmit this patch, including changes based on comments by various people. - Mention

Re: [MERGE] Rework urlAbsolute to be a little more streamlined.

2008-09-01 Thread Amos Jeffries
On Mon, 2008-09-01 at 12:42 +1000, Benno Rice wrote: Resubmit this patch, including changes based on comments by various people. - Mention RFC text in relation to changing the default behaviour in relation to unknown HTTP methods. - Use safe_free instead of xfree. - Rework urlAbsolute

Re: Refresh patterns and ACLs

2008-09-01 Thread Mark Nottingham
On 29/08/2008, at 11:20 PM, Henrik Nordstrom wrote: On fre, 2008-08-29 at 10:44 +1000, Mark Nottingham wrote: I'm not convinced it's a great solution, but something like URISpace may be appropriate; http://www.w3.org/TR/urispace.html Not very different in function, besides being XML..

Re: [squid-users] binary data in cache.log with squid 3.0

2008-09-01 Thread Amos Jeffries
Amos Jeffries escreveu: Leonardo Rodrigues Magalhães wrote: i dont know if this is expected or even desired but with squid 3.0 i'm getting some log entries that brings lots of binary data to the log. This binary stuff makes it impossible, sometimes, to watch logs with 'tail -f' or

Re: binary data

2008-09-01 Thread Adrian Chadd
Erk! I just read that patch! man isprint. Oh, and man ctype. I'm sure there's a C++ equivalent somewhere which makes more sense to use. Adrian 2008/9/2 Amos Jeffries [EMAIL PROTECTED]: Henrik, Theres been some user interest in porting the binary data hack

Re: pseudo-specs for a String class

2008-09-01 Thread Amos Jeffries
On Sun, 2008-08-31 at 14:07 +0200, Kinkie wrote: I've gotten a bit forward, now I'm a bit at a loss about where to go next. I would move string, stream, and other formatting functions away from this class. I would move searching and comparison functions away from this class. I would

Re: [MERGE] Rework urlAbsolute to be a little more streamlined.

2008-09-01 Thread Alex Rousskov
On Tue, 2008-09-02 at 13:44 +1200, Amos Jeffries wrote: There got to be some way to remove this code duplication (and related inconsistencies)! That duplication and a lot more URL mess is all covered by Bug 1961. http://www.squid-cache.org/bugs/show_bug.cgi?id=1961 Since the original

Re: pseudo-specs for a String class

2008-09-01 Thread Kinkie
Thanks for this extra feedback. I appreciate the advice everyone is giving. I'll have limited access to the net for the next couple of days so I won't be able to answer to the points you make right away, I should have the time to incorporate some of your suggestions by then. Are you! On

Re: pseudo-specs for a String class

2008-09-01 Thread Kinkie
Er.. That was a 'see you', as mangled by a BlackBerry. On 9/2/08, Kinkie [EMAIL PROTECTED] wrote: Thanks for this extra feedback. I appreciate the advice everyone is giving. I'll have limited access to the net for the next couple of days so I won't be able to answer to the points you make

Re: [MERGE] Bug #2447: Problems on failed DNS TCP connections

2008-09-01 Thread Martin Pool
Martin Pool has voted comment. Status is now: Waiting Comment: retargetting... For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C1220137897.6703.4.camel%40henriknordstrom.net%3E Project: Squid