Re: client_side and comm_close

2008-09-04 Thread Alex Rousskov
> On Sun, 20 Apr 2008 22:44:22 -0600, Alex Rousskov wrote: > > > What if we let the close callback to determine how it should be called? > > Old code gets an "immediate" close callback (the default in v3.1). The > > code that was written to handle async calls uses asynchronous callbacks. > > This

Re: [PATCH] string-safe improvements in basic-auth session helper

2008-09-04 Thread Henrik Nordstrom
That patches the MSNT/SMB helper (msnt_auth), not the session helper.. ons 2008-09-03 klockan 22:25 +1200 skrev Amos Jeffries: > Advanced testing reveals that the session helper does not use the > string-safe functions Squid should be using. > > This patch corrects that and a bit of formatting

Comm API notes

2008-09-04 Thread Alex Rousskov
Hello, As a part of Squid3 cleanup and planning, I promised to assemble Comm API-related notes from a few squid-dev threads and bring them in sync with the current implementation. The first draft of that documentation is below, FYI. This is a work-in-progress and no formal review is requested

Re: [MERGE] Further cleanup of urlAbsolute and friends.

2008-09-04 Thread Henrik Nordstrom
ons 2008-09-03 klockan 16:30 +1200 skrev Amos Jeffries: > > Declaring variables as needed rather than in advance makes code > > maintenance easier and might help the compiler to optimize. Not a big > > deal though. > > But it does needlessly break the oldest-possible-compiler policy. In Squid-2 t

Re: pseudo-specs for a String class: tokenization

2008-09-04 Thread Alex Rousskov
On Fri, 2008-09-05 at 00:43 +0200, Kinkie wrote: > On Thu, Sep 4, 2008 at 7:30 PM, Alex Rousskov > <[EMAIL PROTECTED]> wrote: > > On Thu, 2008-09-04 at 18:00 +0200, Kinkie wrote: > > > >> > BTW, this is yet another case where a Tokenizer class would be better > >> > than let-String-do-everything ap

Re: pseudo-specs for a String class: tokenization

2008-09-04 Thread Kinkie
On Thu, Sep 4, 2008 at 7:30 PM, Alex Rousskov <[EMAIL PROTECTED]> wrote: > On Thu, 2008-09-04 at 18:00 +0200, Kinkie wrote: > >> > BTW, this is yet another case where a Tokenizer class would be better >> > than let-String-do-everything approach because a tokenizer object can at >> > any time return

Re: [RFC] COSS removal from 3.0

2008-09-04 Thread Alex Rousskov
On Fri, 2008-09-05 at 01:46 +1200, Amos Jeffries wrote: > I'm expecting to roll 3.0.STABLE9 sometime over the next 5 days. > > One update still to be done is the removal of COSS. > > I had planned on just dead-coding (disabling) it. But with the configure > recursion being dynamic thats not easi

Re: pseudo-specs for a String class: tokenization

2008-09-04 Thread Alex Rousskov
On Thu, 2008-09-04 at 18:00 +0200, Kinkie wrote: > > BTW, this is yet another case where a Tokenizer class would be better > > than let-String-do-everything approach because a tokenizer object can at > > any time return the current token, the current delimiter, and/or both, > > without performance

Re: pseudo-specs for a String class: tokenization

2008-09-04 Thread Kinkie
On Thu, Sep 4, 2008 at 5:24 PM, Alex Rousskov <[EMAIL PROTECTED]> wrote: > On Thu, 2008-09-04 at 11:29 +0200, Kinkie wrote: > >> /** >> * strtok()-equivalent, without (some of) the brain-damage. >> * Will extract a token from the beginning of the KBuf, containing >> * all chars u

Re: pseudo-specs for a String class: tokenization

2008-09-04 Thread Alex Rousskov
On Thu, 2008-09-04 at 11:29 +0200, Kinkie wrote: > /** > * strtok()-equivalent, without (some of) the brain-damage. > * Will extract a token from the beginning of the KBuf, containing > * all chars up to the first occurrence of any of the chars in > * delim or end-of-KBuf i

Re: [RFC] COSS removal from 3.0

2008-09-04 Thread Adrian Chadd
2008/9/4 Amos Jeffries <[EMAIL PROTECTED]>: > I'm expecting to roll 3.0.STABLE9 sometime over the next 5 days. > > One update still to be done is the removal of COSS. > > I had planned on just dead-coding (disabling) it. But with the configure > recursion being dynamic thats not easily possible. >

Re: [RFC] translation back-ports

2008-09-04 Thread Kinkie
On Thu, Sep 4, 2008 at 4:35 PM, Amos Jeffries <[EMAIL PROTECTED]> wrote: > It's time I think to start making the older branches of Squid more > compatible with the langpack translations. > > The plan is to immediately: > > - merge back the templates directory contents as if it was a new language.

[RFC] translation back-ports

2008-09-04 Thread Amos Jeffries
It's time I think to start making the older branches of Squid more compatible with the langpack translations. The plan is to immediately: - merge back the templates directory contents as if it was a new language. - make those templates the default hard-coded language files instead of English

Re: Update of "Features/FeatureTemplate"

2008-09-04 Thread Alex Rousskov
On Thu, 2008-09-04 at 23:23 +1200, Amos Jeffries wrote: > Alex Rousskov wrote: > > On Thu, 2008-09-04 at 04:59 +, [EMAIL PROTECTED] wrote: > > > >> The following page has been changed by Amos Jeffries: > >> http://wiki.squid-cache.org/Features/FeatureTemplate?action=diff&rev1=3&rev2=4 > >> > >

[RFC] COSS removal from 3.0

2008-09-04 Thread Amos Jeffries
I'm expecting to roll 3.0.STABLE9 sometime over the next 5 days. One update still to be done is the removal of COSS. I had planned on just dead-coding (disabling) it. But with the configure recursion being dynamic thats not easily possible. I'm currently considering dropping an #error abortio

Re: Update of "Features/FeatureTemplate"

2008-09-04 Thread Amos Jeffries
Alex Rousskov wrote: On Thu, 2008-09-04 at 04:59 +, [EMAIL PROTECTED] wrote: The following page has been changed by Amos Jeffries: http://wiki.squid-cache.org/Features/FeatureTemplate?action=diff&rev1=3&rev2=4 The comment on the change is: update template to mention who things get auto-lis

Re: pseudo-specs for a String class: tokenization

2008-09-04 Thread Kinkie
On Thu, Sep 4, 2008 at 6:59 AM, Alex Rousskov <[EMAIL PROTECTED]> wrote: > On Thu, 2008-09-04 at 13:47 +1200, Amos Jeffries wrote: > >> >> On an unrelated issue, since it was of interest to some of us, here's >> >> a sample of the caller code for tokenization functions (actual live >> >> code): >>